Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__ is reserved for introspection #2805

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Conversation

saerdnaer
Copy link
Contributor

@saerdnaer saerdnaer commented Apr 6, 2021

Related #2804

graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2021

🦋 Changeset detected

Latest commit: 7322572

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244
@ardatan
Copy link
Owner

ardatan commented Apr 7, 2021

Thanks for the fix :) Could you add a changeset using yarn changeset?

@saerdnaer
Copy link
Contributor Author

Done – but I'm not sure if I answered the questions correctly...

@ardatan ardatan requested a review from yaacovCR April 12, 2021 14:51
@yaacovCR yaacovCR merged commit a4f1ee5 into ardatan:master Apr 12, 2021
@saerdnaer saerdnaer deleted the fix-fake branch April 12, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants