Apply suggestions from code review

graphql · Apr 17, 2023 · 3fdbfdd · 3fdbfdd
1 parent 4092fe2
commit 3fdbfdd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/graphiql-react/src/editor/header-editor.ts b/packages/graphiql-react/src/editor/header-editor.ts
@@ -98,8 +98,8 @@ export function useHeaderEditor(
       newEditor.on('keyup', (editorInstance, event) => {
         const { code, key, shiftKey } = event;
         const isLetter = code.startsWith('Key');
-        const isNumber = code.startsWith('Digit');
-        if (isLetter || (!shiftKey && isNumber) || key === '_' || key === '"') {
+        const isNumber = !shiftKey && code.startsWith('Digit');
+        if (isLetter || isNumber || key === '_' || key === '"') {
           editorInstance.execCommand('autocomplete');
         }
       });

diff --git a/packages/graphiql-react/src/editor/variable-editor.ts b/packages/graphiql-react/src/editor/variable-editor.ts
@@ -118,8 +118,8 @@ export function useVariableEditor(
       newEditor.on('keyup', (editorInstance, event) => {
         const { code, key, shiftKey } = event;
         const isLetter = code.startsWith('Key');
-        const isNumber = code.startsWith('Digit');
-        if (isLetter || (!shiftKey && isNumber) || key === '_' || key === '"') {
+        const isNumber = !shiftKey && code.startsWith('Digit');
+        if (isLetter || isNumber || key === '_' || key === '"') {
           editorInstance.execCommand('autocomplete');
         }
       });