replace rest of event.keyCode usages by event.code

graphql · Apr 14, 2023 · 4092fe2 · 4092fe2
1 parent 4879984
commit 4092fe2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/graphiql-react/src/editor/header-editor.ts b/packages/graphiql-react/src/editor/header-editor.ts
@@ -96,9 +96,9 @@ export function useHeaderEditor(
       });
 
       newEditor.on('keyup', (editorInstance, event) => {
-        const { keyCode, key, shiftKey } = event;
-        const isLetter = keyCode >= 65 && keyCode <= 90;
-        const isNumber = keyCode >= 48 && keyCode <= 57;
+        const { code, key, shiftKey } = event;
+        const isLetter = code.startsWith('Key');
+        const isNumber = code.startsWith('Digit');
         if (isLetter || (!shiftKey && isNumber) || key === '_' || key === '"') {
           editorInstance.execCommand('autocomplete');
         }

diff --git a/packages/graphiql-react/src/editor/variable-editor.ts b/packages/graphiql-react/src/editor/variable-editor.ts
@@ -116,9 +116,9 @@ export function useVariableEditor(
       });
 
       newEditor.on('keyup', (editorInstance, event) => {
-        const { keyCode, key, shiftKey } = event;
-        const isLetter = keyCode >= 65 && keyCode <= 90;
-        const isNumber = keyCode >= 48 && keyCode <= 57;
+        const { code, key, shiftKey } = event;
+        const isLetter = code.startsWith('Key');
+        const isNumber = code.startsWith('Digit');
         if (isLetter || (!shiftKey && isNumber) || key === '_' || key === '"') {
           editorInstance.execCommand('autocomplete');
         }