Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ v3.0.0 ☂️ #1355

Merged
merged 1 commit into from
Sep 26, 2022
Merged

☂️ v3.0.0 ☂️ #1355

merged 1 commit into from
Sep 26, 2022

Conversation

firaskafri
Copy link
Collaborator

No description provided.

Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@firaskafri firaskafri merged commit ed7c995 into main Sep 26, 2022
@firaskafri firaskafri deleted the bump-to-3.0.0 branch September 26, 2022 12:08
@ulgens
Copy link
Collaborator

ulgens commented Sep 26, 2022

:/ Wasn't it too fast for a major release, come on guys. At least give couple days to other maintainers.

@ulgens
Copy link
Collaborator

ulgens commented Sep 26, 2022

Also, when and where people decided to make a new release with the current state of the repo? Slack is completely silent. Please give a quick update before making it. I understand and appreciate the enthusiasm but there are better ways to handle this.

@tcleonard
Copy link
Collaborator

tcleonard commented Sep 26, 2022

What do you mean by "the current state of the repo"?
I agree we should have waited for a couple of maintainers before cutting a release.
But that one has been baking for a long time and we still didn't have a release compatible with graphene V3 leading for confusion in the community.
@ulgens anything that you think was missing before releasing this V3 version?
All functionalities previously supported by the V2 are working in V3 so I don't really see a reason to wait... And tags are cheap! We can patch after if need be

@ulgens
Copy link
Collaborator

ulgens commented Sep 26, 2022

@tcleonard I mean, we should have created a checklist, at least. I was expecting #1336 to be merged first, for example. There are a bunch of important issues that got closed without any solution or explanation. I'm trying to follow what is going on but it's all going too fast and I can't really catch why is the rush.

@firaskafri
Copy link
Collaborator Author

Hi @ulgens
The release has been practically ready since a little bit less than two years, checklist for the release is already done as per this issuer here #705 .

Basically if we are releasing this today, then yesterday was the best time to do it. So as pointed out by @jkimbo the sooner we release this the better.

I agree with you that this happened too fast, but this is only for getting this specific release out. We can all agree on a better process structure of releasing for any upcoming release.

superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants