👷 Add pre-commit #1336
👷 Add pre-commit #1336
Conversation
nikolaik
force-pushed
the
chore/pre-commit
branch
from
5464cf1
to
1d37fa6
Compare
nikolaik
changed the title
|
Instead of sending a big chunk of changes, can you please create smaller PRs with only 1 or 2 of the pre-commit rules? This is pretty hard to review as is. |
|
@ulgens +1, or just remove the commit that applies the changes and a maintainer runs pre-commit locally to ensure nothing else was changed by accident. Adding black or the other hooks won't introduce breaking changes. |
Similar to graphene and graphene-sqlalchemy
nikolaik
force-pushed
the
chore/pre-commit
branch
2 times, most recently
from
de8b39d
to
5d7516f
Compare
Yup, wasn't sure on how to include the actual formatting changes. Reverted the formatting changes so they can be applied by a maintainer instead |
|
@nikolaik @erikwrede If you guys are okay with waiting for 2-3 days, I'll recommend something else. We should remove Django 2.2 and Python 3.6 from the test matrix, and with their removal, the code should be updated. I can prioritize that cleaning and then we can apply other styling related pre-commit config. |
nikolaik
force-pushed
the
chore/pre-commit
branch
from
fe89095
to
c9b9428
Compare
Good idea! Something like this #1337 ? |
|
Hello @nikolaik ! Would you please resolve conflicts so we can merge this? |
nikolaik
changed the title
Hi @firaskafri fixed the conflicts now. There are test failures (which are also present on main) and I left the actual formatting up to a maintainer as suggested. |
Hi @nikolaik, fixed the previous change that caused tests to fail, but now seems to be some errors with this PR, can you please help? |
@firaskafri merged with main to fix issues with tests, should be ready to go now! |
Tests seem to still fail :( |
dedent docs/schema.py to allow formatting
Ah, you mean the linter checks. Here you go 81787d9 |
* 🔧 Add pre-commit config Similar to graphene and graphene-sqlalchemy * ⬆ Bump black * 👷 Lint on CI * ⬆ Bump flake8-black * 🔧 Keep excluding migrations * ⬆ Bump flake8 * 🔧 Remove black and flake8 from tox config * ⬆ Update pre-commit versions * Upgrade syntax to python 3.7+ * Format with pre-commit dedent docs/schema.py to allow formatting * Fix tests on python 3.7
This adds pre-commit rules (similar to graphene) and enforcement on CI.