Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphQL to v15 #410

Closed
Moumouls opened this issue Apr 8, 2020 · 3 comments · Fixed by #486
Closed

Update GraphQL to v15 #410

Moumouls opened this issue Apr 8, 2020 · 3 comments · Fixed by #486
Labels
community/help-wanted Not our focus, but accepting PRs type/feat Add a new capability or enhance an existing one

Comments

@Moumouls
Copy link

Moumouls commented Apr 8, 2020

GraphQL get a major release with v15.
GraphQL tools/utlis are gradually moving to the new version.
v15 GraphQL Schemas will break with v14 GraphQL Schemas when they are merged.

What do you think about this ?
@Moumouls Moumouls mentioned this issue Apr 8, 2020
Closed
@Sytten
Copy link
Collaborator

Sytten commented Jun 12, 2020

Would be very nice to see this lands, version is now 15.1.0.

@Moumouls
Copy link
Author

It seems now that graphql is listed as a peer dependency, so if you encounter some issues like GraphQL version mismatch, just update to the last version of nexus.

Note: if you have nexus package listed into your package.json, you probably need to migrate your dep.

  1. Remove nexus dep
  2. Install the new nexus dep yarn add @nexus/schema or npm i @nexus/schema
  3. Replace all nexus (import or require) with @nexus/schema

And then you should be right 👍

@Sytten
Copy link
Collaborator

Sytten commented Jun 15, 2020

Still annoying that its not listed in the peer deps as compatible, I didn't see any error though. I will try to run the tests with 15.1 and see if everything passes, maybe its just a matter of updating the package.json.

@jasonkuhrt jasonkuhrt mentioned this issue Jun 24, 2020
Closed
@jasonkuhrt jasonkuhrt added community/help-wanted Not our focus, but accepting PRs type/feat Add a new capability or enhance an existing one labels Jun 24, 2020
@jasonkuhrt jasonkuhrt mentioned this issue Aug 7, 2020
Closed
jasonkuhrt added a commit that referenced this issue Aug 7, 2020
@jasonkuhrt
feat(deps)!: upgrade to graphql v15
4c55c3d 
closes #410

BREAKING CHANGE:

Support for graphql v14 and lower has been dropped. It may technically
work still (the test suite did not show any major reasons why it won't,
for now/currently) but there is no guarantee about that remaining so in
the future. Certain new grpahqljs v15 features like interfaces being
able to implement other interfaces will be released in the future.

If you absolutely cannot upgrade from graphql v14 right now then stay
with @nexus/schema v15. But if you also really need a new @nexus/schema
feature on v16+ (future) then you _can_ try your luck with it an older
version of graphqljs.
@jasonkuhrt jasonkuhrt mentioned this issue Aug 7, 2020
Merged
jasonkuhrt pushed a commit that referenced this issue Aug 7, 2020
feat(deps)!: upgrade to graphql v15 (#486)
0ee644b 
closes #410

BREAKING CHANGE:

The graphql peer dep requirement has been bumped to v15.

No graphql v15 exclusive features have been shipped yet. But this update
sets us up to begin that work.

Support for graphql v14 and lower has been dropped. It may technically work
still (the test suite did not show any major reasons why it won't, for
now/currently) but there is no guarantee about that remaining so in the
future. Internally we are only testing against v15. Certain new grpahqljs
v15 features like interfaces being able to implement other interfaces will
be released in the future.

If you absolutely cannot upgrade from graphql v14 right now then stay with
@nexus/schema v15. But if you also really need a new @nexus/schema feature
on v16+ (future) then you can try your luck with it an older version of
graphqljs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/help-wanted Not our focus, but accepting PRs type/feat Add a new capability or enhance an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deps)!: upgrade to graphql v15 graphql-nexus/nexus
3 participants
@jasonkuhrt @Sytten @Moumouls