Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Wait before merging last major version of GraphQL #6577

Closed
Moumouls opened this issue Apr 7, 2020 · 8 comments
Closed

GraphQL: Wait before merging last major version of GraphQL #6577

Moumouls opened this issue Apr 7, 2020 · 8 comments

Comments

@Moumouls
Copy link
Member

Moumouls commented Apr 7, 2020

Last version of Parse Server (4.2.0) was released with GraphQL 15.0.0.

I think we should wait before upgrading graphql to a major release because it can break and currently breaks merged schemas that use packages with another version like GraphQL Nexus or graphql tools.

Parse users will be stopped by the following Apollo Error :

Invalid options provided to ApolloServer: Cannot use GraphQLObjectType \"RoleConnection\" from another module or realm.\n\nEnsure that there is only one instance of \"graphql\"

This error cannot be resolved until the other tools allow the use of the latest version...

@Moumouls Moumouls added type:bug Impaired feature or lacking behavior that is likely assumed discussion labels Apr 7, 2020
@Moumouls
Copy link
Member Author

Moumouls commented Apr 7, 2020

We should probably downgrade graphql to ^14.5.8 and release a new parser 4.2.1 ?

@TomWFox
Copy link
Contributor

TomWFox commented Apr 7, 2020

I wonder whether it would be clearer and easier if we just add a clear note to the changelog and release note?

@davimacedo
Copy link
Member

@Moumouls I believe it will break till the moment the other packages will also upgrade to GraphQL 15.0, right? Since the tests are all passing, I believe we should not consider it a breaking change and I'd go with @TomWFox suggestion of a big disclaimer in the release notes.

@Moumouls
Copy link
Member Author

Moumouls commented Apr 8, 2020

GraphQL Tools is on the road: ardatan/graphql-tools#1353
I opened an issue on Nexus: graphql-nexus/nexus#410

@dotansimha
Copy link

It's currently WIP if graphql-tools, which shouldn't effect itself because it's using graphql as a peer dependency.
Is there a reason to have a direct dependency to graphql in this package? why not having it as dev+peer and allow people to install their own version of GraphQL?

Also, if you are using Yarn, you can solve that with resolutions field as a workaround.

@TomWFox TomWFox removed the type:bug Impaired feature or lacking behavior that is likely assumed label Apr 15, 2020
@Moumouls
Copy link
Member Author

I may be wrong but we can't use peer dependency system since parse server should run solo without installing any other dependency.

@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 26, 2020
@stale stale bot closed this as completed Jul 3, 2020
@zanderisrael
Copy link

any updates on this matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants