Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Graphql-js version #55

Closed
wants to merge 13 commits into from
Closed

Conversation

amian84
Copy link

@amian84 amian84 commented Sep 17, 2018

Hi @IvanGoncharov, I did a upgrade of graphql-js version and modify some code for work correclty.
With that, now the new description syntaxt are working but I don't know if all work propertly because for our propuse only need that (#41 ).

Also i had to disable the lint into codemirror because with the update, if you define any type on the schema always show an error about the type definition, the error is becuase is not executable... Maybe you can fix that.

I do the pull-request only for if you would like start your migration to new version with this base.

Thanks for all

@IvanGoncharov
Copy link
Member

@amian84 Thanks for PR 👍
I have an urgent work so I will take a look next weekends.

@amian84
Copy link
Author

amian84 commented Sep 18, 2018

I added more changes fixing when you extend another fake schema. If you try extend another faker schema, the buildSchema function failed because the system defines the faker schema more than once

@heiso
Copy link

heiso commented Nov 9, 2018

Hey here ? Any news on this PR ?

@nilehmann
Copy link

What about now? Any news?

@arquio
Copy link

arquio commented May 23, 2019

Any news? thanks

@amian84
Copy link
Author

amian84 commented May 23, 2019

guys, while accept PR you can clone my repository and checkout to 'distFolder' branch, then you can execute 'sudo npm link' and with that your global graphql-faker binary will be my build with the changes.

@IvanGoncharov
Copy link
Member

@amian84 Thanks a lot for PR 👍
I used it as reference for migration, see recent commits.
I released 2.0.0-rc.1 📦 that use the most recent graphql and express-graphql.
If you have time can you please test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants