Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline SDL descriptions causes errors #41

Closed
joshprice opened this issue Mar 14, 2018 · 2 comments
Closed

Inline SDL descriptions causes errors #41

joshprice opened this issue Mar 14, 2018 · 2 comments

Comments

@joshprice
Copy link

GraphQL SDL now supports inline descriptions as documentation (http://facebook.github.io/graphql/draft/#sec-Descriptions), but this throws errors in the editor.

This looks to be an issue with the fork and branch (https://github.com/apis-guru/graphql-js/tree/directives-fork-dist) that graphql-faker relies on in https://github.com/APIs-guru/graphql-faker/blob/master/package.json#L48).

Currently that branch is > 500 commits behind. Is there anything preventing this from being updated to the latest?

@IvanGoncharov
Copy link
Member

IvanGoncharov commented Mar 14, 2018

Currently that branch is > 500 commits behind.

Yeah I know, ~50 of those are mine 😄

Is there anything preventing this from being updated to the latest?

The main issue is that this project based on my first implementation of directives support in graphql-js which was rejected. After that, I managed to push very basic support for directives at graphql/graphql-js#746

Initially, I planned to push all necessary functionality to graphql-js and when to rewrite this project to remove all hacks and workarounds. But it seems it taking to much time and missing support for new SDL syntax is a real issue so I think the time has come.

As a first step, I would try to update it to vanilla v0.10.4 since it's the first version having at least some directive support: https://github.com/graphql/graphql-js/releases/tag/v0.10.4

@IvanGoncharov
Copy link
Member

@joshprice I finally migrated away from forked graphql and released 2.0.0-rc.1 📦 with this change.
If you have time can you please test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants