feat: execute/subscribe AsyncIterable API #211
Conversation
|
n1ru4l
force-pushed
the
feat-context-per-subscription-event
branch
4 times, most recently
from
ab73859 to
b667b3f
Compare
…implementations this will actually ensure the finally block is always invoked.
| executeRaw: makeExecute(async (args: ExecutionArgs) => { | ||
| const proxy = initRequest(); | ||
| return await proxy.execute({ | ||
| ...args, | ||
| contextValue: await proxy.contextFactory(args.contextValue), | ||
| }); | ||
| }), |
There was a problem hiding this comment.
@dotansimha At the moment the testkit is pretty helix tailored. I assume this is in order to be more integration test-like, and closer to how envelop is used with actual network layers?
I added this method here for now, but maybe we should in that case just construct all the stuff in place within the test?
There was a problem hiding this comment.
I think we can remove helix for testing, I initially used it because I wanted to test envelop with a request, but it's no longer needed.
n1ru4l
changed the title
This is a POC for hooking into the phases of the async iterable returned from execute or subscribe (similar to the approach described in #182).It is currently based upon
#187 and#183. It should be rebased once it is merged into main.~~The idea is to let the
onSubscribeResultandonExecuteDonehandlers return an object with the propertiesonNextandonFinalwhich will be invoked in case we have an async iterable.Currently, tests are missing, as I first want to gather feedback on whether this could be the way to go.The relevant commit is aea90c4