Skip to content

additional defer/stream/subscription helix example #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2021
Merged

additional defer/stream/subscription helix example #187

merged 1 commit into from
May 30, 2021

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented May 14, 2021

The helix example could act as a mirror for the experimental graphql playground repo 🤔

image

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2021

⚠️ No Changeset found

Latest commit: 1c09874

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ee0d137). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage        ?   80.00%           
=======================================
  Files           ?       28           
  Lines           ?      685           
  Branches        ?      149           
=======================================
  Hits            ?      548           
  Misses          ?      137           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0d137...1c09874. Read the comment docs.

@dotansimha
Copy link
Member

Oh @n1ru4l , just noticed that you applied that on top of the original helix example. I wanted to keep it clean and straightforward with just Query/Mutation. Can you please clone this dir into examples/graphql-helix-stream-defer directory?

@n1ru4l n1ru4l changed the title defer and stream for helix-examples additional defer/stream/subscription helix example May 27, 2021
@n1ru4l
Copy link
Collaborator Author

n1ru4l commented May 27, 2021

@dotansimha Done!

@maraisr
Copy link

maraisr commented May 27, 2021

Instead of fastify may I suggest we use polka in examples? It's faster than fastify 👀

@dotansimha
Copy link
Member

Instead of fastify may I suggest we use polka in examples? It's faster than fastify 👀

Hi @maraisr ! We are always open for new ideas. In this case, we are trying to add examples for reference, so maybe we can have an example with polka in addition to fastify. I'm not highly familiar with polka - so feel free to create a PR ;)

@dotansimha dotansimha merged commit 66c8d2c into graphql-hive:main May 30, 2021
@n1ru4l n1ru4l deleted the feat-extend-helix-example branch May 30, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants