Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to fmt.Print for error logging #777

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

julienduchesne
Copy link
Member

When an error occurs, it is ultimately brought to the main.go file where it is printed for the user (or machine)
Using log.Fatal garbles the error by not rendering newlines

This reverts #774 but adds an os.Exit(1) which is an alternative fix to what the PR did

When an error occurs, it is ultimately brought to the `main.go` file where it is printed for the user (or machine)
Using log.Fatal garbles the error by not rendering newlines

This reverts #774 but adds an os.Exit(1) which is an alternative fix to what the PR did
@julienduchesne julienduchesne requested a review from a team October 13, 2022 02:32
@julienduchesne julienduchesne merged commit 2709a0a into main Oct 13, 2022
@julienduchesne julienduchesne deleted the julienduchesne/os.exit branch October 13, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants