Exit with a non-zero status on cmd execution errors #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvrplmlmn
force-pushed
the
jvrplmlmn/rootcmd-fatal-on-error
branch
from
10d6ff2
to
b4c11d9
Compare
julienduchesne
approved these changes
Oct 5, 2022
julienduchesne
added a commit
that referenced
this pull request
Oct 13, 2022
When an error occurs, it is ultimately brought to the `main.go` file where it is printed for the user (or machine) Using log.Fatal garbles the error by not rendering newlines This reverts #774 but adds an os.Exit(1) which is an alternative fix to what the PR did
julienduchesne
added a commit
that referenced
this pull request
Oct 13, 2022
When an error occurs, it is ultimately brought to the `main.go` file where it is printed for the user (or machine) Using log.Fatal garbles the error by not rendering newlines This reverts #774 but adds an os.Exit(1) which is an alternative fix to what the PR did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address a behaviour change that made it via #766
We were able to identify this issue at GrafanaLabs because we run Tanka in our CI pipelines and on errors, Tanka was still exiting with 0, executing the subsequent steps of the pipeline.