Only update helm repositories when necessary #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently run `helm repo update` every time we run `tk tool charts vendor`. Some tanka users may check in their charts directory to avoid many network calls to helm repositories in CI, which can be flaky. By delaying the `helm repo update` call until there is a chart to pull, we can better support these workflows.
Closed
|
@sh0rez wdyt? |
sh0rez
approved these changes
Mar 18, 2021
|
Thanks! We're going to start using this at GitLab right away, to reduce transient helm repository errors in our tanka pipelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run
helm repo updateevery time we runtk tool charts vendor. Some tanka users may check in their charts directory to avoidmany network calls to helm repositories in CI, which can be flaky. By
delaying the
helm repo updatecall until there is a chart to pull, wecan better support these workflows.
Hopefully a non-broken version of #507!