Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is entirely possible I've missed something important, but I can't figure out why
helm repo update
ever needs to be run by tanka. As far as I can tell, tanka execs helm in 2 contexts:helm pull
, as part oftk tool charts vendor
, andhelm template
, as part of rendering jsonnet.The
helm pull
invocation passes--repository-config
with a freshly created temporary helm repo file. Thehelm repo update
invocation that precedeshelm pull
also passes in--repository-config
, with a different freshly created tempfile, that is never used again.The
helm template
invocation in pkg/helm/jsonnet.go passes in a local path to the already-vendored chart, and does not interact with remote repositories.If I'm right, removing this code speeds up
tk tool charts vendor
by removing an unnecessary network call, and if the correct chart versions are already present on the filesystem, no network calls will be made at all, due to the idempotence introduced in #420. This helps make CI flows that cache/vendor helm charts more reliable.Draft in case I'm totally wrong about this call being unncessary!