Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): ignore nil during reconcile #162

Merged
merged 2 commits into from
Jan 13, 2020
Merged

fix(kubernetes): ignore nil during reconcile #162

merged 2 commits into from
Jan 13, 2020

Commits on Jan 13, 2020

  1. fix(kubernetes): ignore nil during reconcile 

    While extracting the objects from the Jsonnet output, Tanka was not correctly
dealing with keys that were set to `nil`, leading those to be classified as
invalid objects, while they were no objects at all.

Such a case, where a key is explicitely set to `nil` is Jsonnet if:

```jsonnet
{
  key: if false then "ouch"
}
```

Because the condition is false, Jsonnet adds an implicit `else null`.
    @sh0rez
    sh0rez committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    2f3a158 View commit details
    Browse the repository at this point in the history

  2. test(kubernetes): reconcile ignore nil

    @sh0rez
    sh0rez committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    294fdc0 View commit details
    Browse the repository at this point in the history