fix(kubernetes): ignore nil during reconcile #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While extracting the objects from the Jsonnet output, Tanka was not correctly
dealing with keys that were set to `nil`, leading those to be classified as
invalid objects, while they were no objects at all.
Such a case, where a key is explicitely set to `nil` is Jsonnet if:
```jsonnet
{
key: if false then "ouch"
}
```
Because the condition is false, Jsonnet adds an implicit `else null`.
sh0rez
added
kind/bug
rfratto
approved these changes
Jan 13, 2020
of course, will do |
rfratto
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While extracting the objects from the Jsonnet output, Tanka was not correctly
dealing with keys that were set to
nil, leading those to be classified asinvalid objects, while they were no objects at all.
Such a case, where a key is explicitely set to
nilis Jsonnet if:{ key: if false then "ouch" }Because the condition is false, Jsonnet adds an implicit
else null.Fixes #160