Refactoring: Create a common ring configuration #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Sep 11, 2023
kolesnikovae
approved these changes
Sep 12, 2023
Comment on lines
-38
to
-49
| -distributor.ring.heartbeat-period duration | ||
| Period at which to heartbeat to the ring. 0 = disabled. (default 5s) | ||
| -distributor.ring.heartbeat-timeout duration | ||
| The heartbeat timeout after which distributors are considered unhealthy within the ring. 0 = never (timeout disabled). (default 1m0s) | ||
| -distributor.ring.instance-addr string | ||
| IP address to advertise in the ring. | ||
| -distributor.ring.instance-id string | ||
| Instance ID to register in the ring. (default "<hostname>") | ||
| -distributor.ring.instance-interface-names string | ||
| Name of network interface to read address from. (default [<private network interfaces>]) | ||
| -distributor.ring.instance-port int | ||
| Port to advertise in the ring (defaults to server.http-listen-port). (default 4040) |
There was a problem hiding this comment.
Just to double check: we're hiding these config options from the short output, not removing them, right?
There was a problem hiding this comment.
Correct those are removed from the normal output (all has it).
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to copy the code again for compaction and decided to end it here.
This basically refactors all component to use the same
RingConfigstruct. Added bonus the generated doc is now more consistent.