Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc page on ingester reactive limiters #10591

Merged
merged 21 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7e56297
Add doc page on ingester adaptive limiters
jhalterman Feb 6, 2025
eb304fe
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
f65b867
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
d1bf171
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
77b9b0b
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
5b6cfa7
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
442389a
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
51f8758
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
0dd3cec
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
153dd82
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
01b8251
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
8e17f8c
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
a9ca7ef
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
4be0fa1
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
5ebe041
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
37f7920
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
8e333ee
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
6e7b98e
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
8685c8c
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
jhalterman Feb 7, 2025
7598977
Update docs based on PR comments
jhalterman Feb 7, 2025
6bb3ed8
Rename adaptive to reactive
jhalterman Feb 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
  • Loading branch information
jhalterman and tacole02 authored Feb 7, 2025
commit f65b8677919974bf7e6a31947eec689347e46e48
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Mimir's adaptive concurrency limiters automatically adapt concurrency limits bas

Adaptive limiters detect overload by observing response times, inflight requests, and throughput.

When recent response times increase significantly relative to the longer term trend, an adaptive limiter will temporarily decrease concurrency limits to avoid potential overload. Similarly, when increasing inflight requests correlate with flat or decreasing throughput and increasing response times, this is taken as a sign of overload and the concurrency limit is decreased.
When recent response times increase significantly relative to the longer term trend, an adaptive limiter temporarily decreases concurrency limits to avoid potential overload. Similarly, when increasing inflight requests correlate with flat or decreasing throughput and increasing response times, this indicates overload and causes an adaptive limiter to decrease concurrency limits.

## How do adaptive limiters behave in practice?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this heading to How adaptive limiters work ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section above was meant to be about how they work, and this section was meant to be more about how they behave. Did you want to shorten this section to How do adaptive limiters behave?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually do away with the heading and just have everything under How adaptive limiters work.


Expand Down
Loading