Add doc page on ingester reactive limiters #10591
Update docs/sources/mimir/configure/about-ingester-adaptive-limiters.md
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
- Loading branch information
commit eb304fe81a090b3432a911107386abf727d2372a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the feature called
adaptive limiters,adaptive concurrency limiters, oringester adaptive limiters? We should choose one and standardize throughout the doc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adaptive concurrency limiters, which I'd call adaptive limiters for short. I wrote this doc originally based on the about ingester circuit breakers doc, which is why I mentioned ingester in a few places. My preference would be to not though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just refer to them as
adaptive limitersthroughout. You mention in the description that they adapt concurrency limits to guard against ingester overload, so I think just sayingadaptive limitersis sufficiently clear.