Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Set default value for BatchWait as ticker does not accept 0 #973

Merged
merged 1 commit into from
Sep 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Set default value for BatchWait as ticker does not accept 0
  • Loading branch information
ctrox committed Sep 5, 2019
commit 7bb3e2f3e0800db97eadf8927a7cb1af72096957
4 changes: 2 additions & 2 deletions pkg/promtail/client/multi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ func TestNewMulti(t *testing.T) {
}
host1, _ := url.Parse("http://localhost:3100")
host2, _ := url.Parse("https://grafana.com")
expectedCfg1 := Config{BatchSize: 20, URL: flagext.URLValue{URL: host1}}
expectedCfg2 := Config{BatchSize: 10, URL: flagext.URLValue{URL: host2}}
expectedCfg1 := Config{BatchSize: 20, BatchWait: 1 * time.Second, URL: flagext.URLValue{URL: host1}}
expectedCfg2 := Config{BatchSize: 10, BatchWait: 1 * time.Second, URL: flagext.URLValue{URL: host2}}

clients, err := NewMulti(util.Logger, expectedCfg1, expectedCfg2)
if err != nil {
Expand Down