Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Set default value for BatchWait as ticker does not accept 0 #973

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Sep 5, 2019

What this PR does / why we need it:
I have seen that my PR (#969) got merged and the tests broke on master, sorry about that. I have no idea why it did not fail in my branch though.

Which issue(s) this PR fixes:
The failing test as the ticker cannot take a zero value.

@ctrox ctrox changed the title Set default value for BatchWait as ticker does not accept 0 tests: Set default value for BatchWait as ticker does not accept 0 Sep 5, 2019
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping an eye on this!!

@slim-bean slim-bean merged commit 6b51805 into grafana:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants