[new] chunk backend: Integrate Alibaba Cloud oss #8410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/sources/configuration/_index.md # docs/sources/configuration/examples.md # go.mod # go.sum # pkg/storage/config/schema_config.go # pkg/storage/factory.go # vendor/modules.txt
github-actions
bot
added
the
type/docs
3 tasks
owen-d
approved these changes
Feb 9, 2023
| @@ -0,0 +1,40 @@ | |||
| package alibaba | |||
There was a problem hiding this comment.
Let's remove this file -- it's not regularly run and checks for keys Prom/prometheus which isn't guaranteed to exist. I think it's easier to remove.
liguozhong
changed the title
remove test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is in preparation for another PR review（https://github.com/grafana/loki/pull/5522）, mainly to resolve code conflicts after the merge master branch.
Which issue(s) this PR fixes:
Fixes (#5522)
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md