Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: histogram could measure up to 10 seconds of consumption lag, needs exponential buckets #16897

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 25, 2025

What this PR does / why we need it:

This pull request fixes a bug where the histogram could not measure more than 10 seconds of lag, as DefBuckets stops at 10. We need to use ExponentialBuckets like the other consumption lag metrics.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 25, 2025 12:01
@grobinson-grafana grobinson-grafana enabled auto-merge (squash) March 25, 2025 12:19
@grobinson-grafana grobinson-grafana merged commit 3986b86 into main Mar 25, 2025
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-metric-buckets branch March 25, 2025 14:19
grobinson-grafana added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants