feat: add loki_ingest_limits_kafka_consumption_lag_seconds metric #16886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a previous metric that did not measure consumption lag as intended, replacing it with a new metric that estimates the consumption lag in seconds using the timestamp in the record.
grobinson-grafana
force-pushed
the
grobinson/add-kafka-consumption-lag-metric-ingest-limits
branch
from
fc1beff to
27e0d67
Compare
| Namespace: constants.Loki, | ||
| Name: "ingest_limits_kafka_read_latency_seconds", | ||
| Help: "Latency to read stream metadata from Kafka.", | ||
| kafkaConsumptionLag: promauto.With(reg).NewHistogram(prometheus.HistogramOpts{ |
There was a problem hiding this comment.
I am reluctant to put the partition as a label here to avoid really high cardinality (one histogram each for 1000 partitions).
| Name: "ingest_limits_kafka_read_latency_seconds", | ||
| Help: "Latency to read stream metadata from Kafka.", | ||
| kafkaConsumptionLag: promauto.With(reg).NewHistogram(prometheus.HistogramOpts{ | ||
| Name: "loki_ingest_limits_kafka_consumption_lag_seconds", |
There was a problem hiding this comment.
Also renamed to match loki_kafka_reader_consumption_lag_seconds.
periklis
approved these changes
Mar 25, 2025
grobinson-grafana
deleted the
grobinson/add-kafka-consumption-lag-metric-ingest-limits
branch
grobinson-grafana
added a commit
that referenced
this pull request
Mar 25, 2025
6 tasks
grobinson-grafana
added a commit
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds a new metric to the ingest-limits service to track consumption lag in seconds.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR