chore(dependabot): Remove enable auto-merge #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some debugging and discussing with internal security squad, the core problem for the this permission issue with auto-merge is ``` GraphQL: ["Pull request User is not authorized for this protected branch"] (enablePullRequestAutoMerge) ``` The settings "Restrict who can push it to protected branch" rule we have `main` branch. And currently no way to add `github-action` user to this list (there is an open discussion https://github.com/orgs/community/discussions/25305 I proposed an idea to use some "real" user's (even grafana-bot) token to do the "auto-merge". But that is still under review by security squad. Meanwhile, to unblock merging any dependabot PR, I'm removing this check. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
ashwanthgoli
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After some debugging and discussing with internal security squad, the core problem for the this permission issue with auto-merge is
The settings "Restrict who can push it to protected branch" rule we have
mainbranch.And currently no way to add
github-actionuser to this list (there is an open discussion https://github.com/orgs/community/discussions/25305I proposed an idea to use some "real" user's (even grafana-bot) token to do the "auto-merge". But that is still under review by security squad.
Meanwhile, to unblock merging any dependabot PR, I'm removing this step.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Related to #10126 #10141 #10144
Checklist
CONTRIBUTING.mdguide (required)