chore(CODEOWNERS): Add dependabot as codeowners for dependencies #10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dependabot as codeowner for dependencies related files. This is needed because, we have branch protection rule (for `main` branch) with "Required review of code owners" as one of the checks Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajk
commented
Aug 2, 2023
| @@ -6,3 +6,8 @@ | |||
|
|
|||
| # No owners - allows sub-maintainers to merge changes. | |||
| CHANGELOG.md | |||
|
|
|||
| # Make dependabot as codeowners for specific files to auto-merge dependencies PRs | |||
| go.mod @dependabot @grafana/loki-team | |||
There was a problem hiding this comment.
Check PR description about this error on @dependabot user.
|
@dependabot user |
1 task
kavirajk
added a commit
that referenced
this pull request
Aug 3, 2023
**What this PR does / why we need it**: After some debugging and discussing with internal security squad, the core problem for the this permission issue with auto-merge is ``` GraphQL: ["Pull request User is not authorized for this protected branch"] (enablePullRequestAutoMerge) ``` The settings "Restrict who can push it to protected branch" rule we have `main` branch. And currently no way to add `github-action` user to this list (there is an open discussion https://github.com/orgs/community/discussions/25305 I proposed an idea to use some "real" user's (even grafana-bot) token to do the "auto-merge". But that is still under review by security squad. Meanwhile, to unblock merging any dependabot PR, I'm removing this step. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: Related to #10126 #10141 #10144 **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add dependabot as codeowner for dependencies related files (
go.mod,go.sumand/vendor)This is needed because, we have branch protection rule (for
mainbranch) with "Required review of code owners" as one of the checksWhich issue(s) this PR fixes:
Fixes #NA
Special notes for your reviewer:
Follow up to #10126
NOTE: Github linter may show "@dependabot is unknown and may not have write permission for the repo" But that's fine. I tested it on my personal repository.
example: Before having it as CODEOWNERS.
kavirajk/dependabot-play#10 (GH action waited for another user from CODOWNER to review before merging)
example: After adding it to CODEOWNERS
kavirajk/dependabot-play#13 (GH action merged the PR because approve from dependabot is good enough as it's code owner for
go.modrelated files)Checklist
CONTRIBUTING.mdguide (required)