Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.ebpf: update dependency #5902

Merged
merged 2 commits into from
Dec 1, 2023
Merged

pyroscope.ebpf: update dependency #5902

merged 2 commits into from
Dec 1, 2023

Conversation

korniltsev
Copy link
Contributor

PR Description

Bum pyroscope ebpf dependency to include fixes for issues grafana/pyroscope#2788 (causing unoptimal pprof profiles for python profiles) and grafana/pyroscope#2778 (causing mem leak preventing profiling regular processes istead of kthreads)

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested a review from a team as a code owner December 1, 2023 06:26
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@korniltsev korniltsev merged commit 5c0fa9b into main Dec 1, 2023
10 checks passed
@korniltsev korniltsev deleted the ebpf-fixes-update branch December 1, 2023 06:53
@yashsarma
Copy link

@korniltsev thanks for the fix. Do we know when the next minor release would take place?

@korniltsev
Copy link
Contributor Author

I dont think #5902 was considered for backporting.

This is not a recommendation but if you are brave enough you could try using main-{ref} builds including this fix

https://hub.docker.com/layers/grafana/agent/main-5c0fa9b/images/sha256-48107439093c71dcdddd25161eb2c9b9c3f1e79a38e45b872946bf703453427a?context=explore

BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants