fix(ebpf): merge equal samples #2788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Dec 1, 2023
| Value: []int64{scaledValue}, | ||
| } | ||
| p.sampleHashToSample[h] = sample | ||
| p.tmpLocations = nil |
| p.tmpLocationIDs = append(p.tmpLocationIDs, loc.ID) | ||
| } | ||
| p.hash.Reset() | ||
| if _, err := p.hash.Write(uint64Bytes(p.tmpLocationIDs)); err != nil { |
Collaborator
There was a problem hiding this comment.
Do we need to Write? Is there a way to Sum64([]byte)?
korniltsev
added a commit
that referenced
this pull request
Dec 1, 2023
korniltsev
added a commit
that referenced
this pull request
Dec 1, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular stacktraces are agregated in ebpf program by increasing value in the ebpf maps
Python stacktraces are different, they are sent to userspace as is without any aggregation, so we may end up with multiple equal samples and values=1.
In this PR I aggregate python samples so that pprofs are smaller.
In the future we may try to aggregate python samples in ebpf (this require adding hashing function to ebpf)