Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeable value on gradio.Slider #2329

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Typeable value on gradio.Slider #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
898866c
typeable number slider
dawoodkhan82 Sep 24, 2022
0cf5d9c
Merge branch 'main' into dawood/936
dawoodkhan82 Sep 26, 2022
3529bf9
fix hardcoded files in test configs
dawoodkhan82 Sep 26, 2022
8dcaab0
test
dawoodkhan82 Sep 26, 2022
f4c0d14
test fix
dawoodkhan82 Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
cache: pnpm
cache-dependency-path: ui/pnpm-lock.yaml
- run: pip install -r ../requirements.txt
- run: pip install gradio
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abidlabs added this in order to run the create_demo_configs.py file, which creates the configs for the integration tests. Confused how the tests were passing without this.

- run: pnpm install --frozen-lockfile
- run: pnpm exec playwright install chromium
- run: pnpm build
Expand Down
2 changes: 1 addition & 1 deletion demo/blocks_inputs/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
"headers": [],
"samples": [
[
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/blocks_inputs/lion.jpg"
"lion.jpg"
]
],
"type": "index",
Expand Down
54 changes: 27 additions & 27 deletions demo/kitchen_sink/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,14 +758,14 @@
],
"baz",
"bar",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/world.mp4",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/titanic.csv",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"world.mp4",
"cantina.wav",
"cantina.wav",
"titanic.csv",
[
[
1,
Expand All @@ -778,7 +778,7 @@
5
]
],
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/time.csv"
"time.csv"
],
[
"the quick brown fox",
Expand All @@ -793,14 +793,14 @@
],
"baz",
"bar",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/world.mp4",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/titanic.csv",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"world.mp4",
"cantina.wav",
"cantina.wav",
"titanic.csv",
[
[
1,
Expand All @@ -813,7 +813,7 @@
5
]
],
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/time.csv"
"time.csv"
],
[
"the quick brown fox",
Expand All @@ -828,14 +828,14 @@
],
"baz",
"bar",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cheetah1.jpg",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/world.mp4",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/cantina.wav",
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/titanic.csv",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"cheetah1.jpg",
"world.mp4",
"cantina.wav",
"cantina.wav",
"titanic.csv",
[
[
1,
Expand All @@ -848,7 +848,7 @@
5
]
],
"/Users/dawoodkhan/Desktop/Developer/gradio/demo/kitchen_sink/files/time.csv"
"time.csv"
]
],
"type": "index",
Expand Down
2 changes: 1 addition & 1 deletion ui/packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build:website": "vite build --mode production:website --emptyOutDir",
"build:local": "vite build --mode production:local --emptyOutDir",
"preview": "vite preview",
"test:browser": "pnpm exec python test/create_demo_configs.py && pnpm exec playwright test test/ --config=../../playwright.config.js",
"test:browser": "python test/create_demo_configs.py && pnpm exec playwright test test/ --config=../../playwright.config.js",
"test:browser:debug": "pnpm exec playwright test test/ --debug --config=../../playwright.config.js"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions ui/packages/app/test/kitchen_sink.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ test("test inputs", async ({ page }) => {

const uploaded_image = await page.locator("img").nth(0);
const image_data = await uploaded_image.getAttribute("src");
await expect(image_data).toEqual(BASE64_IMAGE);
await expect(image_data).toContain("cheetah1.jpg");

// Image Input w/ Cropper
const image_cropper = await page.locator("input").nth(10);
await image_cropper.setInputFiles("./test/files/cheetah1.jpg");

const uploaded_image_cropper = await page.locator("img").nth(0);
const image_data_cropper = await uploaded_image_cropper.getAttribute("src");
await expect(image_data_cropper).toEqual(BASE64_IMAGE);
await expect(image_data_cropper).toContain("cheetah1.jpg");
});

test("test outputs", async ({ page }) => {
Expand Down
16 changes: 11 additions & 5 deletions ui/packages/form/src/Range.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<script lang="ts">
import { createEventDispatcher } from "svelte";
import { BlockTitle } from "@gradio/atoms";
import { create_classes } from "@gradio/utils";
import { get_styles } from "@gradio/utils";
import type { Styles } from "@gradio/utils";

export let value: number = 0;
Expand All @@ -18,20 +18,26 @@
export let show_label: boolean;

const id = `range_id_${_id++}`;

const dispatch = createEventDispatcher<{ change: number }>();

$: dispatch("change", value);
$: ({ classes } = get_styles(style, ["rounded", "border"]));
</script>

<div class="w-full flex flex-col ">
<div class="flex justify-between">
<label for={id}>
<BlockTitle {show_label}>{label}</BlockTitle>
</label>
<div class={"font-medium dark:text-gray-300" + create_classes(style)}>
{value}
</div>
<input
type="number"
class="gr-box gr-input gr-text-input text-center h-6 {classes}"
bind:value
min={minimum}
max={maximum}
{step}
{disabled}
/>
</div>
</div>

Expand Down