-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeable value on gradio.Slider #2329
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2329-all-demos |
Very nice @dawoodkhan82! Tested and works really well, not sure what's up with that test though |
Fixed tests, by updating test configs + updating kitchen sink Image input tests |
6deb1f7
to
898866c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -54,6 +54,7 @@ jobs: | |||
cache: pnpm | |||
cache-dependency-path: ui/pnpm-lock.yaml | |||
- run: pip install -r ../requirements.txt | |||
- run: pip install gradio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abidlabs added this in order to run the create_demo_configs.py
file, which creates the configs for the integration tests. Confused how the tests were passing without this.
Is it possible to enable/disable it ? or change width of the input field ? |
Hi @siraxe can you share a screenshot so we have an idea of how it looks? @dawoodkhan82 what do you think about adding a |
Looks like this |
Description
Allows slider value to be typeable.
Screen.Recording.2022-09-23.at.11.01.43.PM.mov
Please include:
Closes: #936
Checklist: