Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeable value on gradio.Slider #2329

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Typeable value on gradio.Slider #2329

merged 5 commits into from
Sep 27, 2022

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Allows slider value to be typeable.

Screen.Recording.2022-09-23.at.11.01.43.PM.mov

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: #936

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2329-all-demos

@abidlabs
Copy link
Member

abidlabs commented Sep 24, 2022

Very nice @dawoodkhan82! Tested and works really well, not sure what's up with that test though

@dawoodkhan82 dawoodkhan82 requested a review from pngwn September 26, 2022 14:43
@dawoodkhan82 dawoodkhan82 self-assigned this Sep 26, 2022
@dawoodkhan82
Copy link
Collaborator Author

Fixed tests, by updating test configs + updating kitchen sink Image input tests

@dawoodkhan82 dawoodkhan82 force-pushed the dawood/936 branch 2 times, most recently from 6deb1f7 to 898866c Compare September 26, 2022 20:16
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -54,6 +54,7 @@ jobs:
cache: pnpm
cache-dependency-path: ui/pnpm-lock.yaml
- run: pip install -r ../requirements.txt
- run: pip install gradio
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abidlabs added this in order to run the create_demo_configs.py file, which creates the configs for the integration tests. Confused how the tests were passing without this.

@dawoodkhan82 dawoodkhan82 merged commit 55e6f40 into main Sep 27, 2022
@dawoodkhan82 dawoodkhan82 deleted the dawood/936 branch September 27, 2022 03:00
@siraxe
Copy link

siraxe commented Oct 3, 2022

Is it possible to enable/disable it ? or change width of the input field ?
Have a lot of small sliders and naming starts to overlap/distort the element

@abidlabs
Copy link
Member

abidlabs commented Oct 3, 2022

Hi @siraxe can you share a screenshot so we have an idea of how it looks?

@dawoodkhan82 what do you think about adding a typeable=True parameter into the Slider that configures this?

@siraxe
Copy link

siraxe commented Oct 3, 2022

Looks like this
https://user-images.githubusercontent.com/27487254/193601220-5d4ea46e-524b-4c5c-a667-f7b909ac2076.mp4
Maybe there's a way to override css options with js or something to at least change their width or yeah having typeable=True would be great as well )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeable value on gradio.Slider
4 participants