Skip to content

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Dec 9, 2025

Issue: #4523


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from kainino0x December 9, 2025 22:16
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as #4521, how many tests does this break until browsers finish implementing the new limits? Looks like it's mostly just the relevant test cases, but I'm not sure about the changes in capability_info.ts. You know better how getDefaultLimits would affect tests.

We could start with the specialized tests (capability_checks/limits), and give other browsers time to fix those first.

@greggman
Copy link
Contributor Author

greggman commented Dec 9, 2025

I don't think it's going to affect that many tests. There's the specific limits tests. Then, checking calls to getDefaultLimits, there's only webgpu:idl,javascript;limits

@greggman greggman force-pushed the update-limits-tests-for-compat branch from 9e7818a to dbb257a Compare December 9, 2025 23:02
@greggman greggman enabled auto-merge (squash) December 9, 2025 23:02
@greggman greggman merged commit fcf2a82 into gpuweb:main Dec 9, 2025
1 check passed
@greggman greggman deleted the update-limits-tests-for-compat branch December 9, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants