Skip to content

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Dec 9, 2025

This reverts commit b500efd.

Compatibility mode is now part of the spec.
These limits are now required on all devices.

Issue: #4448, #4523


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from kainino0x December 9, 2025 21:38
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but how many tests does this impact? I.e. how many tests will be broken in browsers until they expose these new limits?

@greggman
Copy link
Contributor Author

greggman commented Dec 9, 2025

not that many? off the top of my head, webgpu:idl, has a couple of tests. requestDevice is in the PR so maybe that. Maybe requestAdapter. I think there might be 1 or 2 others.

I don't have an easy way to check. Running the entire CTS on a single browser takes ~6hrs (assuming it doesn't crash). I can't easily use chrome's CQ without making a change to remove the limits.

…rtexStage' aren't (gpuweb#4448)"

This reverts commit b500efd.

Compatibility mode is now part of the spec.
These limits are now required on all devices.
@greggman greggman force-pushed the renable-compat-limits branch from 269a7c8 to 80fd0b1 Compare December 9, 2025 22:56
@greggman greggman enabled auto-merge (squash) December 9, 2025 22:56
@kainino0x
Copy link
Collaborator

OK, that seems probably fine. We can revert again if needed.

@kainino0x kainino0x mentioned this pull request Dec 9, 2025
8 tasks
@greggman greggman merged commit de2ea6e into gpuweb:main Dec 9, 2025
1 check passed
@greggman greggman deleted the renable-compat-limits branch December 9, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants