Add deprecation warnings on import #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
approved these changes
Sep 3, 2025
pentschev
left a comment
pentschev
left a comment
There was a problem hiding this comment.
I think this looks fine overall, to be completely honest I'm not familiar enough with pth to judge what's being added in setup.py, but I trust you have done what you thought was best and tested as much as you could to ensure it works, therefore I'll approve this. Thanks @vyasr !
Contributor
Author
|
Thanks Peter! I tested in a few environments and it seemed good. I'll defer to @rjzamora on reviewing/approving/merging when ready. We'll need to make a new release once it's merged. |
rjzamora
approved these changes
Sep 4, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warnings to pynvml and pynvml_utils indicating that these packages are going away. For pynvml_utils we could use a simpler approach of just throwing the warning inside the package's
__init__.pyfile, but forpynvmlwe have to use the pth approach since it's just a metapackage relying on nvidia-ml-py for all its code, so we may as well reuse the finder'sfind_specmethod for both warnings.