-
-
Notifications
You must be signed in to change notification settings - Fork 749
pynvml -> nvidia-ml-py in CI
#9111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 7h 9m 36s ⏱️ + 1h 43m 34s For more details on these failures, see this check. Results for commit d1b3be8. ± Comparison against base commit 7024d52. |
|
cc @jameslamb for visibility who has done a bunch of |
pynvml -> nvidia-ml-py in CI
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the @, that summary is exactly right and I agree that distributed should switch to using nvidia-ml-py here in CI.
The new warning is from here: gpuopenanalytics/pynvml#62
rjzamora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent pynvml releases are just "meta-packages" for nvidia-ml-py. So, this change makes perfect sense.
pentschev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Merging based on high number of approvals from folks without merge rights but good expertise here. Thanks all! |
Attempt to resolve #9110
The warning in #9110 is about a failure to parse the warning to parse the warning from
pynvmlFutureWarning: The pynvml package is deprecated. Please install nvidia-ml-py instead. If you did not install pynvml directly, please report this to the maintainers of the package that installed pynvml for you.This PR resolves it by following the advice of the warning and switching to the
nvidia-ml-pypackage, rather than digging into the parsing error. We could look at this too, but this PR resolves the immediate issue.The
nvidia-ml-pypackage also provides thepynvmllibrary and still usesimport pynvmlbut is more officially maintained than thepynvmlpackage on PyPI/conda-forge. Recent releases ofpynvmljust depend onnvidia-ml-pyand raise this warning when imported.pre-commit run --all-files