Merge projects to single repository #85
Conversation
Required refactoring and test cases being added to the example in order to make it compatible with the latest API.
The aim here is to introduce the set of Gotham examples and over time ensure that folks who are new to the project have a curated path through all the various concepts so as to aid understanding.
Includes updates to have the template compile as part of the overall workspace.
bradleybeddoes
force-pushed
the
merge-projects-to-single-repository
branch
from
b379e99
to
2f3d991
Compare
This appears to be causing build failures when switching between stable, beta and nightly on a single branch.
Why is that necessary? I assume that will slow down builds a lot. |
|
@ChristophWurst errors like this started occurring https://travis-ci.org/gotham-rs/gotham/jobs/326651995#L784 A brief perusal doesn't show times being impacted much, if at all, based on the last few successful builds prior to that change. |
|
I wonder if that's just a temporary issue and clearing the cache once would have helped. |
README.md
Outdated
| To ensure future compatibility, we also run automated builds against Rust beta and | ||
| nightly releases. | ||
| 1. Statically typed. Unlike other web frameworks Gotham is statically typed ensuring your | ||
| entire application is **correctly expressed** at compile time. |
There was a problem hiding this comment.
Unlike other web frameworks
Might be unnecessary
There was a problem hiding this comment.
Copied from website but agree, fixed.
Cargo.toml
Outdated
| [features] | ||
| default = [] | ||
| ci = [] | ||
| "middleware/template", |
examples/README.md
Outdated
|
|
||
| Standalone crates that act as examples for building web applications with Gotham. | ||
|
|
||
| All include test cases that prove correctness and serve as an example of how to test your own applications. |
There was a problem hiding this comment.
prove correctness
"demonstrate correct behaviour" perhaps? 😛
examples/hello_world/src/main.rs
Outdated
| pub fn main() { | ||
| let addr = "127.0.0.1:7878"; | ||
| println!("Listening for requests at http://{}", addr); | ||
| start(addr, || Ok(say_hello)) |
There was a problem hiding this comment.
Not a fan of keeping this explicitly as gotham::start in code? I think importing the bare function makes it a bit harder to see what's going on.
There was a problem hiding this comment.
Agree, gotham::start more useful, especially for newcomers.
Per review suggestion utilise `gotham::start` in all examples to make source explicit.
Previous attempts to get sqlite to build on appveyor using vcpkg didn't work out. As I'm not a Windows user and this is all foreign to me, attempting to adapt the Diesel projects configuration instead which is working fine for them.
|
Something weird going on with Coveralls, so I've temporarily removed the requirement for Coveralls to report everything is ok. |
There ended up being three phases with this PR
Combines the following repositories into the core Gotham repository (these will subsequently be removed once 0.2 ships and marked archived once this PR lands):
Deprecates the following repositories (these will subsequently be removed once 0.2 ships and marked archived once this PR lands):
Deprecating kitchen-sink
The directory
examples/kitchen-sinkhas been removed. Subsequent PR (so each example can be correctly scrutinised) will add back in a number of example crates that will allow developers building Gotham backed apps to succulently explore all the various components that Gotham offers without a singular, over whelming chunk of codeCleaning up README/policies
The intent of these has been kept but there was a lot of extraneous wording that we just didn't need. In the case of the main Gotham README I have also added some best practice sub headings including listing alternate projects.
Closes #76.