Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage reporting to include coverage by doc tests #47

Open
smangelsdorf opened this issue Sep 10, 2017 · 3 comments
Open

Fix coverage reporting to include coverage by doc tests #47

smangelsdorf opened this issue Sep 10, 2017 · 3 comments

Comments

@smangelsdorf
Copy link
Contributor

In many cases, we've got a rustdoc example being used in lieu of a separate test case. These aren't being included by our current test coverage reporting via Travis / Coveralls.

@ELD
Copy link
Contributor

ELD commented Sep 13, 2017

Unfortunately, I don't believe that is possible. Based on the contents of this readme, it appears that the rustdoc example are created in a temporary directory that's disposed of when the destructor of the TempDir struct is run.

I also took a look at the master branch to see if this has changed but it appears to be the same. I don't know if there are plans to make the rustdoc executable remain after test runs or not.

@smangelsdorf
Copy link
Contributor Author

That is unfortunate. Thanks for looking into this. We'll have to park this until the necessary support exists.

@bradleybeddoes
Copy link
Contributor

Following #85 it appears that coverage reporting has been broken completely.

I am guessing this due to our use of cargo test -all now and cargo workspaces.

Investigation required, I wasn't able to sort it in the 30 minutes I spent on it earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants