Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix throttle middleware panic #214

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Feat: Fix throttle middleware panic #214

merged 2 commits into from
Jun 26, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 26, 2023

Closes goravel/goravel#197

πŸ“‘ Description

Fix throttle middleware panic

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@hwbrzzl hwbrzzl changed the base branch from master to v1.12.x June 26, 2023 10:49
@hwbrzzl hwbrzzl requested a review from devhaozi June 26, 2023 10:49
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (6ba0471) 63.00% compared to head (d127442) 62.92%.

❗ Current head d127442 differs from pull request most recent head 2a06612. Consider uploading reports for the commit 2a06612 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.12.x     #214      +/-   ##
===========================================
- Coverage    63.00%   62.92%   -0.09%     
===========================================
  Files          125      125              
  Lines         8067     8078      +11     
===========================================
  Hits          5083     5083              
- Misses        2636     2647      +11     
  Partials       348      348              
Impacted Files Coverage Ξ”
http/service_provider.go 0.00% <0.00%> (ΓΈ)

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 54ce17e into v1.12.x Jun 26, 2023
@hwbrzzl hwbrzzl deleted the bowen/v1.12.4 branch June 26, 2023 11:28
hwbrzzl added a commit that referenced this pull request Jun 26, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jul 3, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

* fix: Tentative fix for Lazy Eager Loading with uuids (#226)

* tentative fix for Lazy Eager Loading with uuids

* added some unit tests for TestGetIDByReflect

* Add new contributors

* Upgrade v1.12.5

* Upgrade v1.12.5

---------

Co-authored-by: 耗子 <i@haozi.net>
Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
hwbrzzl added a commit that referenced this pull request Jul 28, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

* fix: Tentative fix for Lazy Eager Loading with uuids (#226)

* tentative fix for Lazy Eager Loading with uuids

* added some unit tests for TestGetIDByReflect

* Add new contributors

* Upgrade v1.12.5

* Upgrade v1.12.5

* Upgrade v1.12.7

* Update README

---------

Co-authored-by: 耗子 <i@haozi.net>
Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] Throttle middleware panic when update to v1.12.x
2 participants