Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path error in Windows #192

Merged
merged 3 commits into from
Jun 19, 2023
Merged

fix: path error in Windows #192

merged 3 commits into from
Jun 19, 2023

Conversation

devhaozi
Copy link
Member

Closes goravel/goravel#181

πŸ“‘ Description

Fix path error in Windows and optimize code.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

none.

filesystem/file.go Outdated Show resolved Hide resolved
filesystem/file.go Outdated Show resolved Hide resolved
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Jun 19, 2023

CI failed

@devhaozi
Copy link
Member Author

CI failed

fixed

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 40.62% and project coverage change: -0.08 ⚠️

Comparison is base (891abfb) 61.84% compared to head (d3b683d) 61.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   61.84%   61.77%   -0.08%     
==========================================
  Files         125      125              
  Lines        8075     8078       +3     
==========================================
- Hits         4994     4990       -4     
- Misses       2753     2757       +4     
- Partials      328      331       +3     
Impacted Files Coverage Ξ”
auth/console/jwt_secret_command.go 0.00% <0.00%> (ΓΈ)
console/console/key_generate_command.go 0.00% <0.00%> (ΓΈ)
filesystem/utils.go 0.00% <0.00%> (ΓΈ)
foundation/path.go 0.00% <0.00%> (ΓΈ)
http/gin_request.go 0.00% <0.00%> (ΓΈ)
support/file/file.go 39.32% <37.50%> (-2.72%) ⬇️
filesystem/file.go 54.28% <55.55%> (-4.54%) ⬇️
foundation/console/vendor_publish_command.go 43.15% <100.00%> (ΓΈ)
log/logrus_writer.go 56.97% <100.00%> (ΓΈ)

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@devhaozi devhaozi merged commit 87db2a7 into master Jun 19, 2023
@devhaozi devhaozi deleted the haozi/fix-path branch June 19, 2023 10:51
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Jun 19, 2023

Oh, I forgot that this PR should be merged into v1.12.x, I'll do it.

@devhaozi
Copy link
Member Author

Oh, I forgot that this PR should be merged into v1.12.x, I'll do it.

ok, thanks.

hwbrzzl added a commit that referenced this pull request Jun 19, 2023
* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jun 19, 2023
* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jun 20, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jun 22, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jun 26, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

---------

Co-authored-by: 耗子 <i@haozi.net>
hwbrzzl added a commit that referenced this pull request Jul 3, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

* fix: Tentative fix for Lazy Eager Loading with uuids (#226)

* tentative fix for Lazy Eager Loading with uuids

* added some unit tests for TestGetIDByReflect

* Add new contributors

* Upgrade v1.12.5

* Upgrade v1.12.5

---------

Co-authored-by: 耗子 <i@haozi.net>
Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
hwbrzzl added a commit that referenced this pull request Jul 28, 2023
* Fix: path error in Windows (#193)

* Update README

* fix: path error in Windows (#192)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Upgrade v1.12.1 (#197)

* Update README

* fix: path error in Windows (#192)

* feat: remove promptui (#194)

* feat: remove promptui

* fix: lint

* fix: lint

* Update README (#195)

---------

Co-authored-by: 耗子 <i@haozi.net>

* Fix: MakeGate error (#199)

* Fix: MakeGate error

* Update print

* Upgrade v1.12.3 (#202)

* Fix the problem of package facades path

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Upgrade v1.12.3

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize action

* Optimize README (#204)

* Feat: Fix throttle middleware panic (#214)

* Feat: Fix throttle middleware error

* Upgrade v1.12.4

* fix: Tentative fix for Lazy Eager Loading with uuids (#226)

* tentative fix for Lazy Eager Loading with uuids

* added some unit tests for TestGetIDByReflect

* Add new contributors

* Upgrade v1.12.5

* Upgrade v1.12.5

* Upgrade v1.12.7

* Update README

---------

Co-authored-by: 耗子 <i@haozi.net>
Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] artisan make:package panic in Windows
2 participants