-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: path error in Windows #192
Conversation
CI failed |
fixed |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 61.84% 61.77% -0.08%
==========================================
Files 125 125
Lines 8075 8078 +3
==========================================
- Hits 4994 4990 -4
- Misses 2753 2757 +4
- Partials 328 331 +3
β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Oh, I forgot that this PR should be merged into v1.12.x, I'll do it. |
ok, thanks. |
* Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net>
* Fix: path error in Windows (#193) * Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net> * Upgrade v1.12.1 (#197) * Update README * fix: path error in Windows (#192) * feat: remove promptui (#194) * feat: remove promptui * fix: lint * fix: lint * Update README (#195) --------- Co-authored-by: θε <i@haozi.net> * Fix: MakeGate error (#199) * Fix: MakeGate error * Update print --------- Co-authored-by: θε <i@haozi.net>
* Fix: path error in Windows (#193) * Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net> * Upgrade v1.12.1 (#197) * Update README * fix: path error in Windows (#192) * feat: remove promptui (#194) * feat: remove promptui * fix: lint * fix: lint * Update README (#195) --------- Co-authored-by: θε <i@haozi.net> * Fix: MakeGate error (#199) * Fix: MakeGate error * Update print * Upgrade v1.12.3 (#202) * Fix the problem of package facades path * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Upgrade v1.12.3 * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize README (#204) --------- Co-authored-by: θε <i@haozi.net>
* Fix: path error in Windows (#193) * Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net> * Upgrade v1.12.1 (#197) * Update README * fix: path error in Windows (#192) * feat: remove promptui (#194) * feat: remove promptui * fix: lint * fix: lint * Update README (#195) --------- Co-authored-by: θε <i@haozi.net> * Fix: MakeGate error (#199) * Fix: MakeGate error * Update print * Upgrade v1.12.3 (#202) * Fix the problem of package facades path * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Upgrade v1.12.3 * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize README (#204) * Feat: Fix throttle middleware panic (#214) * Feat: Fix throttle middleware error * Upgrade v1.12.4 --------- Co-authored-by: θε <i@haozi.net>
* Fix: path error in Windows (#193) * Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net> * Upgrade v1.12.1 (#197) * Update README * fix: path error in Windows (#192) * feat: remove promptui (#194) * feat: remove promptui * fix: lint * fix: lint * Update README (#195) --------- Co-authored-by: θε <i@haozi.net> * Fix: MakeGate error (#199) * Fix: MakeGate error * Update print * Upgrade v1.12.3 (#202) * Fix the problem of package facades path * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Upgrade v1.12.3 * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize README (#204) * Feat: Fix throttle middleware panic (#214) * Feat: Fix throttle middleware error * Upgrade v1.12.4 * fix: Tentative fix for Lazy Eager Loading with uuids (#226) * tentative fix for Lazy Eager Loading with uuids * added some unit tests for TestGetIDByReflect * Add new contributors * Upgrade v1.12.5 * Upgrade v1.12.5 --------- Co-authored-by: θε <i@haozi.net> Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
* Fix: path error in Windows (#193) * Update README * fix: path error in Windows (#192) --------- Co-authored-by: θε <i@haozi.net> * Upgrade v1.12.1 (#197) * Update README * fix: path error in Windows (#192) * feat: remove promptui (#194) * feat: remove promptui * fix: lint * fix: lint * Update README (#195) --------- Co-authored-by: θε <i@haozi.net> * Fix: MakeGate error (#199) * Fix: MakeGate error * Update print * Upgrade v1.12.3 (#202) * Fix the problem of package facades path * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Upgrade v1.12.3 * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize action * Optimize README (#204) * Feat: Fix throttle middleware panic (#214) * Feat: Fix throttle middleware error * Upgrade v1.12.4 * fix: Tentative fix for Lazy Eager Loading with uuids (#226) * tentative fix for Lazy Eager Loading with uuids * added some unit tests for TestGetIDByReflect * Add new contributors * Upgrade v1.12.5 * Upgrade v1.12.5 * Upgrade v1.12.7 * Update README --------- Co-authored-by: θε <i@haozi.net> Co-authored-by: Mariano Peyregne <marianosantafe@gmail.com>
Closes goravel/goravel#181
π Description
Fix path error in Windows and optimize code.
β Checks
βΉ Additional Information
none.