-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic alpha version of the UE4 plugin #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache licences on everything please.
I know nadda about UE4. @luna-duclos would yourself, or someone else at Embarl be good to review this? (unless it already has?)
The only other thought I have, is that we should reference this in our book somewhere. Maybe a new "SDKs" section?
Another thought on having someone with UE4 knowledge give a LGTM - just to double check everything is included, and where it should be. Not something I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I'm an UE4 expert but this code looks good to me, properly structured as UE4 plugin and just wraps the FUniqueSocket
for all calls.
LGTM!
Awesome. Then the only thing blocking for me is getting some documentation into the Guide! |
Build Succeeded 🥳 Build Id: 49ee321e-f6d3-4921-a1b3-4d32f7e8305c To build this version:
|
Adds the basic initial version of the UE4 client, right now it just attaches a routing token and version to the end of the packet.