Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic alpha version of the UE4 plugin #485

Merged
merged 6 commits into from
May 9, 2022
Merged

Add basic alpha version of the UE4 plugin #485

merged 6 commits into from
May 9, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

Adds the basic initial version of the UE4 client, right now it just attaches a routing token and version to the end of the packet.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache licences on everything please.

I know nadda about UE4. @luna-duclos would yourself, or someone else at Embarl be good to review this? (unless it already has?)

The only other thought I have, is that we should reference this in our book somewhere. Maybe a new "SDKs" section?

@markmandel
Copy link
Member

Another thought on having someone with UE4 knowledge give a LGTM - just to double check everything is included, and where it should be. Not something I can do.

sdks/ue4/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm an UE4 expert but this code looks good to me, properly structured as UE4 plugin and just wraps the FUniqueSocket for all calls.

LGTM!

@markmandel
Copy link
Member

I can't say I'm an UE4 expert but this code looks good to me, properly structured as UE4 plugin and just wraps the FUniqueSocket for all calls.

LGTM!

Awesome. Then the only thing blocking for me is getting some documentation into the Guide!

docs/src/sdks.md Outdated Show resolved Hide resolved
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 49ee321e-f6d3-4921-a1b3-4d32f7e8305c

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/485/head:pr_485 && git checkout pr_485
cargo build

@XAMPPRocky XAMPPRocky merged commit d0d32b0 into main May 9, 2022
@markmandel markmandel deleted the ue4-plugin branch May 18, 2022 21:50
@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants