Use fontations glyf/loca builder #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Aug 8, 2023
|
it does make sense to glue the two tables together, you always build them both at the same time, and can't read glyf without loca, and loca by itself is similarly useless |
cmyr
force-pushed
the
use-fontations-glyph
branch
from
64a11bf
to
2adc949
Compare
rsheeter
reviewed
Aug 10, 2023
| // | ||
| // FIXME: Clarify if there's a good reason not to treat glyf/loca as a single | ||
| // entity, for the purpose of persistence? like a struct that contains both | ||
| // tables, and from which the format can be retrieved |
There was a problem hiding this comment.
Given that we compute them together I think this might make more sense and might be a better change. Want to try that?
There was a problem hiding this comment.
Also I really dislike the format wrapper; hopefully use of a single entity would let us avoid that
There was a problem hiding this comment.
yea, it felt very bad writing this code. That said I think it makes sense to merge as is and open an issue, and that work can be a separate patch.
This also uses the LocaFormat type in fontations (which was copied from here) which then forces us to hack around orphan rules.
cmyr
force-pushed
the
glyf-loca-builder
branch
from
43063d3
to
34dc594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #382
This also uses the LocaFormat type in fontations (which was copied from here) which then forces us to hack around orphan rules.
Playing around with this i have a better understanding of the annoyance we encountered previously about serializing loca. The main question this patch raised for me, was whether or not we should just have a
GlyfAndLocastruct that wraps both those tables, as they're always generated together? This would let us simplify some of our serialization code.