Use fontations Glyph enum #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
approved these changes
Aug 8, 2023
This renames the backend 'Glyph' type to 'NamedGlyph', and turns it into a simple struct, containing a `write-fonts` Glyph and the associated name. This also lets us delete the GlyphPersistable type, since we don't need to store a flag indicating whether the glyph is simple or composite.
cmyr
force-pushed
the
use-fontations-glyph
branch
from
64a11bf
to
2adc949
Compare
rsheeter
reviewed
Aug 10, 2023
| Composite(GlyphName, CompositeGlyph), | ||
| pub struct NamedGlyph { | ||
| pub name: GlyphName, | ||
| pub glyph: Glyph, | ||
| } |
There was a problem hiding this comment.
NamedGlyph suggests the existence of other types but there really aren't any. I'd rather call this Glyph and rename the Glyph nested within, e.g.
/// A glyph and its associated name
///
/// See <https://learn.microsoft.com/en-us/typography/opentype/spec/glyf>
#[derive(Debug, Clone)]
pub struct Glyph {
pub name: GlyphName,
pub data: GlyphData,
}
rsheeter
approved these changes
Aug 10, 2023
NamedGlyph goes back to Glyph, and we import write_fonts Glyph as RawGlyph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of cleanup on top of #379.
This renames the backend 'Glyph' type to 'NamedGlyph', and turns it into a simple struct, containing a
write-fontsGlyph and the associated name.This also lets us delete the GlyphPersistable type, since we don't need to store a flag indicating whether the glyph is simple or composite.