Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read with timeout instead of blocking #367

Closed
wants to merge 1 commit into from
Closed

Read with timeout instead of blocking #367

wants to merge 1 commit into from

Commits on Jul 12, 2023

  1. Read with timeout instead of blocking 

    Previously we were using a blocking read to wait for completions, which
would deadlock if a worker thread had panicked.

Now we will read in a loop, and return an error if we timeout.

I've arbitrarily decided that ten seconds is a reasoanble timeout
interval, but it might not be! We also may wish to make this setting
configurable.
    @cmyr
    cmyr committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c50af32 View commit details
    Browse the repository at this point in the history