Read with timeout instead of blocking #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using a blocking read to wait for completions, which would deadlock if a worker thread had panicked. Now we will read in a loop, and return an error if we timeout. I've arbitrarily decided that ten seconds is a reasoanble timeout interval, but it might not be! We also may wish to make this setting configurable.
|
I'm not a fan of adding random timeouts, tends to lead to very confusing
interactions. I suggest we install a proper panic handler and see if that
suffices
…On Wed, Jul 12, 2023, 11:46 AM Colin Rofls ***@***.***> wrote:
Previously we were using a blocking read to wait for completions, which
would deadlock if a worker thread had panicked.
Now we will read in a loop, and return an error if we timeout.
I've arbitrarily decided that ten seconds is a reasoanble timeout
interval, but it might not be! We also may wish to make this setting
configurable.
With this, we will no longer hang (#365
<#365>) although I do think we
should look into better handling of panics (and I'm going to poke at that a
bit more, now)
------------------------------
You can view, comment on, or merge this pull request online at:
#367
Commit Summary
- c50af32
<c50af32>
Read with timeout instead of blocking
File Changes
(2 files <https://github.com/googlefonts/fontc/pull/367/files>)
- *M* fontc/src/error.rs
<https://github.com/googlefonts/fontc/pull/367/files#diff-5d15a72d777fe84b82d28b38c346bd9d1b097dec852212ea6080c898d07d3a3b>
(4)
- *M* fontc/src/workload.rs
<https://github.com/googlefonts/fontc/pull/367/files#diff-26ab2aef3d1aa04dfe9c89d047adf139970f00f49400c5dccdc0148d3157af51>
(44)
Patch Links:
- https://github.com/googlefonts/fontc/pull/367.patch
- https://github.com/googlefonts/fontc/pull/367.diff
—
Reply to this email directly, view it on GitHub
<#367>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRKXAALYZ54BVHJIHX34JLXP22CTANCNFSM6AAAAAA2HTJ4NU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I tend to agree, if you see a timeout that doesn't involve IO it probably means someone made an architectural mistake. Going to look into the more principled options, and depending on how easy that is we can decide if this is a useful stopgap. |
|
superseded by #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a blocking read to wait for completions, which would deadlock if a worker thread had panicked.
Now we will read in a loop, and return an error if we timeout.
I've arbitrarily decided that ten seconds is a reasoanble timeout interval, but it might not be! We also may wish to make this setting configurable.
With this, we will no longer hang (#365) although I do think we should look into better handling of panics (and I'm going to poke at that a bit more, now)