Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 17, 2017

Fixed all flake8 warnings with code F401 (module imported but unused) that appear with the following command:

flake8 --select=F401

@yelsayd
Copy link
Contributor

yelsayd commented Mar 17, 2017

This is great. Cleanup is always much appreciated.

While at it, can we also add the flake command to the travis file so we don't have to batch cleanup again?

@parthea
Copy link
Contributor Author

parthea commented Mar 17, 2017

While at it, can we also add the flake command to the travis file so we don't have to batch cleanup again?

Done for code F401 (unused imports) . I'll work on cleaning up the other flake8 codes so we can just run flake8 . without any filters.

@yelsayd
Copy link
Contributor

yelsayd commented Mar 17, 2017

Awesome! Let me know if you want this PR merged now or if you'll keep working on it to remove the filter.

@parthea
Copy link
Contributor Author

parthea commented Mar 17, 2017

Thanks @yebrahim ! Yes, please merge it. I'll tackle the other codes tomorrow. Hopefully we can remove the filter next week.

@yelsayd yelsayd merged commit 5deca12 into googledatalab:master Mar 17, 2017
@parthea parthea deleted the fix-flake8-F401-unused-imports branch March 17, 2017 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants