Remove unused imports. Fix F401 flake8 warnings. (#313)

parthea · Yasser Elsayed · commit 5deca12bf8bc · 2017-03-17T13:41:35.000-07:00
* Remove unused imports. Fix F401 flake8 warnings.

* Add flake8 to travis. Only report F401 codes for now.
diff --git a/.travis.yml b/.travis.yml
@@ -19,6 +19,12 @@ before_install:
   - pip install solutionbox/image_classification/  
   - pip install -U tensorflow==1.0.0
   - pip install -U protobuf==3.1.0  #v3.2.0 has the "python: double free or corruption" bug.
+  - pip install flake8
+
+before_script:
+  - flake8 . --select=F401
+
+script:
+  - python ./tests/main.py
 
-script: python ./tests/main.py
 
diff --git a/datalab/bigquery/__init__.py b/datalab/bigquery/__init__.py
@@ -29,6 +29,9 @@
 from ._utils import TableName, DatasetName
 from ._view import View
 
+__all__ = ['CSVOptions', 'Dataset', 'Datasets', 'Dialect', 'FederatedTable', 'Query', 'QueryJob',
+           'QueryResultsTable', 'QueryStats', 'Sampling', 'Schema', 'Table', 'TableMetadata',
+           'UDF', 'TableName', 'DatasetName', 'View']
 
 def wait_any(jobs, timeout=None):
   """ Return when at least one of the specified jobs has completed or timeout expires.
diff --git a/datalab/bigquery/commands/__init__.py b/datalab/bigquery/commands/__init__.py
@@ -15,3 +15,4 @@
 
 from . import _bigquery
 
+__all__ = ['_bigquery']
diff --git a/datalab/context/__init__.py b/datalab/context/__init__.py
@@ -15,3 +15,4 @@
 from ._context import Context
 from ._project import Project, Projects
 
+__all__ = ['Context', 'Project', 'Projects']
diff --git a/datalab/context/commands/__init__.py b/datalab/context/commands/__init__.py
@@ -14,3 +14,5 @@
 from __future__ import absolute_import
 
 from . import _projects
+
+__all__ = ['_projects']
diff --git a/datalab/data/__init__.py b/datalab/data/__init__.py
@@ -19,3 +19,4 @@
 from ._sql_statement import SqlStatement
 from ._utils import tokenize
 
+__all__ = ['Csv', 'SqlModule', 'SqlStatement', 'tokenize']
diff --git a/datalab/data/commands/__init__.py b/datalab/data/commands/__init__.py
@@ -13,3 +13,5 @@
 
 
 from . import _sql
+
+__all__ = ['_sql']
diff --git a/datalab/kernel/__init__.py b/datalab/kernel/__init__.py
@@ -19,9 +19,9 @@
 
 try:
   import IPython as _IPython
-  import IPython.core.magic as _magic
+  import IPython.core.magic as _magic # noqa
   import IPython.core.interactiveshell as _shell
-  from IPython import get_ipython
+  from IPython import get_ipython # noqa
 except ImportError:
   raise Exception('This package requires an IPython notebook installation')
 
diff --git a/datalab/notebook/__init__.py b/datalab/notebook/__init__.py
@@ -20,3 +20,4 @@
 def _jupyter_nbextension_paths():
   return [dict(section="notebook", src="static", dest="gcpdatalab")]
 
+__all__ = ['_']
diff --git a/datalab/stackdriver/commands/__init__.py b/datalab/stackdriver/commands/__init__.py
@@ -14,3 +14,5 @@
 from __future__ import absolute_import
 
 from . import _monitoring
+
+__all__ = ['_monitoring']
diff --git a/datalab/stackdriver/monitoring/__init__.py b/datalab/stackdriver/monitoring/__init__.py
@@ -20,3 +20,6 @@
 from ._query import Query
 from ._query_metadata import QueryMetadata
 from ._resource import ResourceDescriptors
+
+__all__ = ['Aligner', 'Reducer', 'Groups', 'MetricDescriptors', 'Query', 'QueryMetadata',
+           'ResourceDescriptors']
diff --git a/datalab/storage/__init__.py b/datalab/storage/__init__.py
@@ -15,3 +15,5 @@
 
 from ._bucket import Bucket, Buckets
 from ._item import Item, Items
+
+__all__ = ['Bucket', 'Buckets', 'Item', 'Items']
diff --git a/datalab/storage/commands/__init__.py b/datalab/storage/commands/__init__.py
@@ -15,3 +15,4 @@
 
 from . import _storage
 
+__all__ = ['_storage']
diff --git a/datalab/utils/__init__.py b/datalab/utils/__init__.py
@@ -23,3 +23,8 @@
 from ._dataflow_job import DataflowJob
 from ._utils import print_exception_with_last_stack, get_item, compare_datetimes, \
                     pick_unused_port, is_http_running_on, gcs_copy_file
+
+__all__ = ['async', 'async_function', 'async_method', 'GCPJob', 'Http', 'RequestException',
+           'Iterator', 'Job', 'JobError', 'JSONEncoder', 'LRUCache', 'LambdaJob', 'DataflowJob',
+           'print_exception_with_last_stack', 'get_item', 'compare_datetimes', 'pick_unused_port',
+           'is_http_running_on', 'gcs_copy_file']
diff --git a/datalab/utils/commands/__init__.py b/datalab/utils/commands/__init__.py
@@ -10,6 +10,8 @@
 # or implied. See the License for the specific language governing permissions and limitations under
 # the License.
 
+# flake8: noqa
+
 from __future__ import absolute_import
 from __future__ import unicode_literals
 
diff --git a/google/datalab/__init__.py b/google/datalab/__init__.py
@@ -12,3 +12,5 @@
 
 from google.datalab._context import Context
 from google.datalab._job import Job, JobError
+
+__all__ = ['Context', 'Job', 'JobError']
diff --git a/google/datalab/bigquery/__init__.py b/google/datalab/bigquery/__init__.py
@@ -27,3 +27,6 @@
 from ._utils import TableName, DatasetName
 from ._view import View
 
+__all__ = ['CSVOptions', 'Dataset', 'Datasets', 'ExternalDataSource', 'Query', 'QueryOutput',
+           'QueryResultsTable', 'QueryStats', 'Sampling', 'Schema', 'SchemaField', 'Table',
+           'TableMetadata', 'UDF', 'TableName', 'DatasetName', 'View']
diff --git a/google/datalab/bigquery/_query.py b/google/datalab/bigquery/_query.py
@@ -22,7 +22,6 @@
 from ._query_output import QueryOutput
 from . import _api
 from . import _query_job
-from . import _sampling
 from . import _udf
 from . import _utils
 from . import _external_data_source
diff --git a/google/datalab/bigquery/_table.py b/google/datalab/bigquery/_table.py
@@ -37,8 +37,6 @@
 from . import _parser
 from . import _schema
 from . import _utils
-from ._query_output import QueryOutput
-from ._sampling import Sampling
 
 
 class TableMetadata(object):
diff --git a/google/datalab/bigquery/_udf.py b/google/datalab/bigquery/_udf.py
@@ -13,11 +13,8 @@
 """Google Cloud Platform library - BigQuery UDF Functionality."""
 from __future__ import absolute_import
 from __future__ import unicode_literals
-from builtins import str
 from builtins import object
 
-import json
-
 
 class UDF(object):
   """Represents a BigQuery UDF declaration.
diff --git a/google/datalab/bigquery/_view.py b/google/datalab/bigquery/_view.py
@@ -20,7 +20,6 @@
 
 from . import _query
 from . import _table
-from ._query_output import QueryOutput
 
 # Query import is at end to avoid issues with circular dependencies.
 
diff --git a/google/datalab/bigquery/commands/__init__.py b/google/datalab/bigquery/commands/__init__.py
@@ -15,3 +15,4 @@
 
 from . import _bigquery
 
+__all__ = ['_bigquery']
diff --git a/google/datalab/bigquery/commands/_bigquery.py b/google/datalab/bigquery/commands/_bigquery.py
@@ -14,7 +14,6 @@
 from __future__ import absolute_import
 from __future__ import print_function
 from __future__ import unicode_literals
-from builtins import zip
 from builtins import str
 from past.builtins import basestring
 
diff --git a/google/datalab/commands/__init__.py b/google/datalab/commands/__init__.py
@@ -17,3 +17,5 @@
 from __future__ import absolute_import
 
 from . import _datalab
+
+__all__ = ['_datalab']
diff --git a/google/datalab/data/__init__.py b/google/datalab/data/__init__.py
@@ -15,3 +15,5 @@
 from __future__ import unicode_literals
 
 from ._csv_file import CsvFile
+
+__all__ = ['CsvFile']
diff --git a/google/datalab/kernel/__init__.py b/google/datalab/kernel/__init__.py
@@ -19,9 +19,9 @@
 
 try:
   import IPython as _IPython
-  import IPython.core.magic as _magic
+  import IPython.core.magic as _magic # noqa
   import IPython.core.interactiveshell as _shell
-  from IPython import get_ipython
+  from IPython import get_ipython # noqa
 except ImportError:
   raise Exception('This package requires an IPython notebook installation')
 
diff --git a/google/datalab/ml/__init__.py b/google/datalab/ml/__init__.py
@@ -10,6 +10,8 @@
 # or implied. See the License for the specific language governing permissions and limitations under
 # the License.
 
+# flake8: noqa
+
 """CloudML Helper Library."""
 
 from __future__ import absolute_import
diff --git a/google/datalab/ml/_feature_slice_view.py b/google/datalab/ml/_feature_slice_view.py
@@ -12,7 +12,6 @@
 
 import json
 import pandas as pd
-from types import ModuleType
 
 import google.datalab as datalab
 import google.datalab.bigquery as bq
diff --git a/google/datalab/ml/_summary.py b/google/datalab/ml/_summary.py
@@ -16,7 +16,6 @@
 
 import datetime
 import fnmatch
-import glob
 import matplotlib.pyplot as plt
 import os
 import pandas as pd
diff --git a/google/datalab/ml/_util.py b/google/datalab/ml/_util.py
@@ -14,7 +14,6 @@
 
 
 from apache_beam.io import gcsio
-import datetime
 import glob
 from googleapiclient import discovery
 import logging
diff --git a/google/datalab/notebook/__init__.py b/google/datalab/notebook/__init__.py
@@ -20,3 +20,4 @@
 def _jupyter_nbextension_paths():
   return [dict(section="notebook", src="static", dest="gcpdatalab")]
 
+__all__ = ['_']
diff --git a/google/datalab/stackdriver/commands/__init__.py b/google/datalab/stackdriver/commands/__init__.py
@@ -14,3 +14,5 @@
 from __future__ import absolute_import
 
 from . import _monitoring
+
+__all__ = ['_monitoring']
diff --git a/google/datalab/stackdriver/monitoring/__init__.py b/google/datalab/stackdriver/monitoring/__init__.py
@@ -20,3 +20,6 @@
 from ._query import Query
 from ._query_metadata import QueryMetadata
 from ._resource import ResourceDescriptors
+
+__all__ = ['Aligner', 'Reducer', 'Groups', 'MetricDescriptors', 'Query', 'QueryMetadata',
+           'ResourceDescriptors']
diff --git a/google/datalab/storage/__init__.py b/google/datalab/storage/__init__.py
@@ -15,3 +15,5 @@
 
 from ._bucket import Bucket, Buckets
 from ._object import Object, Objects
+
+__all__ = ['Bucket', 'Buckets', 'Object', 'Objects']
diff --git a/google/datalab/storage/commands/__init__.py b/google/datalab/storage/commands/__init__.py
@@ -15,3 +15,4 @@
 
 from . import _storage
 
+__all__ = ['_storage']
diff --git a/google/datalab/utils/__init__.py b/google/datalab/utils/__init__.py
@@ -21,3 +21,8 @@
 from ._dataflow_job import DataflowJob
 from ._utils import print_exception_with_last_stack, get_item, compare_datetimes, \
                     pick_unused_port, is_http_running_on, gcs_copy_file
+
+__all__ = ['async', 'async_function', 'async_method', 'Http', 'RequestException', 'Iterator',
+           'JSONEncoder', 'LRUCache', 'LambdaJob', 'DataflowJob',
+           'print_exception_with_last_stack', 'get_item', 'compare_datetimes', 'pick_unused_port',
+           'is_http_running_on', 'gcs_copy_file']
diff --git a/google/datalab/utils/commands/__init__.py b/google/datalab/utils/commands/__init__.py
@@ -10,6 +10,8 @@
 # or implied. See the License for the specific language governing permissions and limitations under
 # the License.
 
+# flake8: noqa
+
 from __future__ import absolute_import
 from __future__ import unicode_literals
 
diff --git a/google/datalab/utils/commands/_utils.py b/google/datalab/utils/commands/_utils.py
@@ -31,7 +31,6 @@
 except ImportError:
   pass
 import sys
-import types
 import yaml
 
 import google.datalab.data
diff --git a/setup.py b/setup.py
@@ -13,13 +13,8 @@
 # To publish to PyPi use: python setup.py bdist_wheel upload -r pypi
 
 import datetime
-import sys
 from setuptools import setup
 
-if sys.version_info[0] == 2:
-  import platform
-  import pip
-
 minor = datetime.datetime.now().strftime("%y%m%d%H%M")
 version = '1.0.' + minor
 
diff --git a/solutionbox/image_classification/mltoolbox/__init__.py b/solutionbox/image_classification/mltoolbox/__init__.py
@@ -1 +1,16 @@
-__import__('pkg_resources').declare_namespace(__name__)
+# Copyright 2017 Google Inc. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ==============================================================================
+
+__import__('pkg_resources').declare_namespace(__name__)
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/__init__.py b/solutionbox/image_classification/mltoolbox/image/classification/__init__.py
@@ -20,4 +20,8 @@
 The trained model can also be deployed online with google.datalab.ml.ModelVersions.deploy() call.
 """
 
-from ._api import preprocess,preprocess_async,train,train_async,predict,batch_predict,batch_predict_async
+from ._api import preprocess, preprocess_async, train, train_async, predict, batch_predict, \
+    batch_predict_async
+
+__all__ = ['preprocess', 'preprocess_async', 'train', 'train_async', 'predict', 'batch_predict',
+           'batch_predict_async']
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_cloud.py b/solutionbox/image_classification/mltoolbox/image/classification/_cloud.py
@@ -18,16 +18,13 @@
 
 import apache_beam as beam
 import base64
-import collections
 import datetime
 import logging
 import os
 import urllib
 
-from . import _model
 from . import _predictor
 from . import _preprocess
-from . import _trainer
 from . import _util
 
 
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_local.py b/solutionbox/image_classification/mltoolbox/image/classification/_local.py
@@ -17,14 +17,7 @@
 """
 
 import apache_beam as beam
-import collections
-import csv
 import datetime
-import json
-import logging
-import os
-import tensorflow as tf
-import yaml
 
 
 from . import _model
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_model.py b/solutionbox/image_classification/mltoolbox/image/classification/_model.py
@@ -17,9 +17,7 @@
 """
 
 from enum import Enum
-import json
 import logging
-import os
 import tensorflow as tf
 from tensorflow.contrib import layers
 from tensorflow.python.ops import control_flow_ops
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_predictor.py b/solutionbox/image_classification/mltoolbox/image/classification/_predictor.py
@@ -20,9 +20,7 @@
 import collections
 import json
 import os
-import tensorflow as tf
 
-from . import _model
 from . import _util
 
 
@@ -108,8 +106,6 @@ class PredictBatchDoFn(beam.DoFn):
   """A DoFn that does batch prediction."""
 
   def __init__(self, model_dir):
-    import os
-
     self._model_dir = model_dir
     self._session = None
     self._tf_inputs = None
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_preprocess.py b/solutionbox/image_classification/mltoolbox/image/classification/_preprocess.py
@@ -21,9 +21,7 @@
 from apache_beam.io import fileio
 from apache_beam.io import tfrecordio
 from apache_beam.metrics import Metrics
-from apache_beam.utils.pipeline_options import PipelineOptions
 import cStringIO
-import csv
 import logging
 import os
 from PIL import Image
diff --git a/solutionbox/image_classification/mltoolbox/image/classification/_util.py b/solutionbox/image_classification/mltoolbox/image/classification/_util.py
diff --git a/solutionbox/structured_data/mltoolbox/__init__.py b/solutionbox/structured_data/mltoolbox/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/__init__.py b/solutionbox/structured_data/mltoolbox/_structured_data/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/_package.py b/solutionbox/structured_data/mltoolbox/_structured_data/_package.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/master_setup.py b/solutionbox/structured_data/mltoolbox/_structured_data/master_setup.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/prediction/__init__.py b/solutionbox/structured_data/mltoolbox/_structured_data/prediction/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/prediction/predict.py b/solutionbox/structured_data/mltoolbox/_structured_data/prediction/predict.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/preprocess/__init__.py b/solutionbox/structured_data/mltoolbox/_structured_data/preprocess/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/preprocess/cloud_preprocess.py b/solutionbox/structured_data/mltoolbox/_structured_data/preprocess/cloud_preprocess.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/trainer/__init__.py b/solutionbox/structured_data/mltoolbox/_structured_data/trainer/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/trainer/task.py b/solutionbox/structured_data/mltoolbox/_structured_data/trainer/task.py
diff --git a/solutionbox/structured_data/mltoolbox/_structured_data/trainer/util.py b/solutionbox/structured_data/mltoolbox/_structured_data/trainer/util.py
diff --git a/solutionbox/structured_data/mltoolbox/classification/__init__.py b/solutionbox/structured_data/mltoolbox/classification/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/classification/dnn/__init__.py b/solutionbox/structured_data/mltoolbox/classification/dnn/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/classification/linear/__init__.py b/solutionbox/structured_data/mltoolbox/classification/linear/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/regression/__init__.py b/solutionbox/structured_data/mltoolbox/regression/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/regression/dnn/__init__.py b/solutionbox/structured_data/mltoolbox/regression/dnn/__init__.py
diff --git a/solutionbox/structured_data/mltoolbox/regression/linear/__init__.py b/solutionbox/structured_data/mltoolbox/regression/linear/__init__.py
diff --git a/solutionbox/structured_data/setup.py b/solutionbox/structured_data/setup.py
diff --git a/solutionbox/structured_data/test_mltoolbox/test_sd_preprocess.py b/solutionbox/structured_data/test_mltoolbox/test_sd_preprocess.py
diff --git a/tests/bigquery/view_tests.py b/tests/bigquery/view_tests.py

Original file line number	Diff line number	Diff line change
`@@ -15,3 +15,4 @@`
`15`	`15`
`16`	`16`	`from . import _bigquery`
`17`	`17`
	`18`	`+__all__ = ['_bigquery']`
Original file line number	Diff line number	Diff line change
`@@ -19,3 +19,4 @@`
`19`	`19`	`from ._sql_statement import SqlStatement`
`20`	`20`	`from ._utils import tokenize`
`21`	`21`
	`22`	`+__all__ = ['Csv', 'SqlModule', 'SqlStatement', 'tokenize']`
Original file line number	Diff line number	Diff line change
`@@ -13,3 +13,5 @@`
`13`	`13`
`14`	`14`
`15`	`15`	`from . import _sql`
	`16`	`+`
	`17`	`+__all__ = ['_sql']`
Original file line number	Diff line number	Diff line change
`@@ -20,3 +20,4 @@`
`20`	`20`	`def _jupyter_nbextension_paths():`
`21`	`21`	`return [dict(section="notebook", src="static", dest="gcpdatalab")]`
`22`	`22`
	`23`	`+__all__ = ['_']`