-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add config .gitattributes #647
build: add config .gitattributes #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two asks for this PR :)
- I would like us to flag the
protos
directory broadly as "generated" code, so linguist stops counting most of our repos as JavaScript. Turns out, you modify.gitattributes
to do that! Figured 92 PRs are better than 184. - I am scared of getting infinity [CHANGE ME] PRs. @bcoe should we do a hammer PR first, or does that break the autosynth tooling? I think for individual commits to work like this, our autosynth backlog has to be super clean.
This should no longer be needed with @SurferJeffAtGoogle's work, changes to synthtool will show up with whatever commit message we use carried over. I would just change this to:
|
Try to understand |
Heh, so feel free to ignore this for now. The context: GitHub shows you the language for a given repository like this: It will also show you the language breakdown in the repo page: GitHub uses linguist to perform this calculation. In our case - half our repos show as Using the |
@JustinBeckwith thanks for context. It is really helpful. So our change should no mess up Before I merge this PR, maybe we should use one nodejs client library to test. Does nodejs-firestore a good one to test or do you have any other suggestion. LMK. Thanks |
You got it! Firestore tends to be a little weird compared to our other repositories. I should have picked a better example. Maybe https://github.com/googleapis/nodejs-scheduler/? |
Cool. Thanks. Will try out on |
test on |
add
.gitattributes
into node template to fix windows linter fail on end of line break issue #464