-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint fails on Windows on end of line break #464
Comments
@bcoe Is there an option to make eslint accept all variations of line endings? |
@SurferJeffAtGoogle great question, I bet that's just a rule we could turn off. |
@bcoe, @SurferJeffAtGoogle The rule to turn off could be |
@summer-ji-eng we could look at turning this off by default, I think that might be a good idea. |
To turn it off by default, one way is add |
resolved in #647 |
Problem:
googleapis/gcs-resumable-upload ci/windows fail due to linter issue of end of line break style for windows (see here)
To temporary unblock me, I removed
posttest
in package.json, hereFix Suggestion from @bcoe:
Instead of add .gitattribute to elf in single repo gcs-resumable-upload for windows (example),
maybe in
.github/workflows/ci.yaml
, add one extra command for windows that just does:run: print "*.ts text eol=lf\n*.js test eol=lf" > .gitattributes
Steps to reproduce
"posttest": "npm run lint",
in repo package.jsonFeel free to @summer-ji-eng if you have any question. Thanks!
The text was updated successfully, but these errors were encountered: