Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable automatically retrieving Universe Domain from Metadata Server #3272

Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix: Disable automatically retrieving Universe Domain from Metadata Server #3272

merged 4 commits into from
Oct 3, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Oct 3, 2024 •
edited
Loading

See internal ticket b/349488459 for more info.

External info:
ComputeEngineCredentials in client libraries should not validate the universe domain. Validating the universe domain requires retrieving it from Metadata Server (MDS) and this will be temporarily disabled.

For users that using client libraries, there will be no automatic call to MDS. For users that use the Credentials directly and manually call ComputeEngineCredentials.getUniverseDomain() and the universe domain is not explicitly set, it will make a call to MDS.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 3, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

blakeli0
blakeli0 reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the title and description to reflect the change before merging? Also this PR probably should be a fix.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@lqiu96 lqiu96 changed the title chore: Disable fetching Universe Domain from MDS fix: Disable automatically retrieving Universe Domain from MDS Oct 3, 2024
@lqiu96 lqiu96 changed the title fix: Disable automatically retrieving Universe Domain from MDS fix: Disable automatically retrieving Universe Domain from Metadata Server Oct 3, 2024
@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 3, 2024

Can we update the title and description to reflect the change before merging? Also this PR probably should be a fix.

Updated and add some external info.

@lqiu96 lqiu96 merged commit f4402bf into main Oct 3, 2024
47 of 50 checks passed
@lqiu96 lqiu96 deleted the disable-mds-universe-domain branch October 3, 2024 21:53
@release-please release-please bot mentioned this pull request Oct 3, 2024
Merged
zhumin8 pushed a commit that referenced this pull request Oct 4, 2024
@release-please
chore(main): release 2.47.0 (#3261)
9ad9591 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.47.0</summary>

##
[2.47.0](v2.46.1...v2.47.0)
(2024-10-04)


### Features

* **gax:** add API key authentication to ClientSettings
([#3137](#3137))
([df08956](df08956))
* **gax:** append cred-type header for auth metrics
([#3186](#3186))
([ca3ec24](ca3ec24))


### Bug Fixes

* address incorrect universe domain validation when quota project id is
set
([#3257](#3257))
([6e70c37](6e70c37)),
closes
[#3256](#3256)
* Disable automatically retrieving Universe Domain from Metadata Server
([#3272](#3272))
([f4402bf](f4402bf))


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.18.0
([#3248](#3248))
([821e83d](821e83d))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3265](#3265))
([94450a9](94450a9))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3266](#3266))
([8235463](8235463))
* update dependency com.google.guava:guava to v33.3.1-jre
([#3228](#3228))
([4e76207](4e76207))
* update dependency net.bytebuddy:byte-buddy to v1.15.3
([#3246](#3246))
([2aad71d](2aad71d))
* update google api dependencies
([#3242](#3242))
([02aae9d](02aae9d))
* update google auth library dependencies to v1.28.0
([#3267](#3267))
([6d85864](6d85864))
* update googleapis/java-cloud-bom digest to 0cd97b7
([#3260](#3260))
([2d54a5d](2d54a5d))
* update grpc dependencies to v1.67.1
([#3258](#3258))
([e08906c](e08906c))
* update grpc dependencies to v1.67.1 in dependencies.properties
([#3279](#3279))
([5b46e70](5b46e70))
* update junit5 monorepo to v5.11.2
([#3276](#3276))
([6b10f94](6b10f94))
* update netty dependencies to v4.1.114.final
([#3263](#3263))
([8bd83d9](8bd83d9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@zhumin8 zhumin8 mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @blakeli0