Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address incorrect universe domain validation when quota project id is set #3257

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix: address incorrect universe domain validation when quota project id is set #3257

merged 3 commits into from
Oct 2, 2024

Conversation

mpeddada1
Copy link
Contributor

Fixes #3256

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 30, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented Oct 1, 2024

I think the changes LGTM. Is it possible to add a showcase test with a client using the QuotaProjectId wrapped Credentials?

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Oct 2, 2024 •
edited
Loading

Good point!

[Reproducer] In c9c70e5, added test that expects UnauthenticationException when setQuotaProjectId is used. Confirmed that it passed:
Screenshot 2024-10-02 at 3 13 07 PM

Brought back fix and showcase test to verify expected behavior in bf0f653.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpeddada1 mpeddada1 merged commit 6e70c37 into main Oct 2, 2024
49 of 50 checks passed
@mpeddada1 mpeddada1 deleted the fix-universe-domain-quota-id branch October 2, 2024 20:39
@release-please release-please bot mentioned this pull request Oct 2, 2024
Merged
zhumin8 pushed a commit that referenced this pull request Oct 4, 2024
@release-please
chore(main): release 2.47.0 (#3261)
9ad9591 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.47.0</summary>

##
[2.47.0](v2.46.1...v2.47.0)
(2024-10-04)


### Features

* **gax:** add API key authentication to ClientSettings
([#3137](#3137))
([df08956](df08956))
* **gax:** append cred-type header for auth metrics
([#3186](#3186))
([ca3ec24](ca3ec24))


### Bug Fixes

* address incorrect universe domain validation when quota project id is
set
([#3257](#3257))
([6e70c37](6e70c37)),
closes
[#3256](#3256)
* Disable automatically retrieving Universe Domain from Metadata Server
([#3272](#3272))
([f4402bf](f4402bf))


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.18.0
([#3248](#3248))
([821e83d](821e83d))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3265](#3265))
([94450a9](94450a9))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3266](#3266))
([8235463](8235463))
* update dependency com.google.guava:guava to v33.3.1-jre
([#3228](#3228))
([4e76207](4e76207))
* update dependency net.bytebuddy:byte-buddy to v1.15.3
([#3246](#3246))
([2aad71d](2aad71d))
* update google api dependencies
([#3242](#3242))
([02aae9d](02aae9d))
* update google auth library dependencies to v1.28.0
([#3267](#3267))
([6d85864](6d85864))
* update googleapis/java-cloud-bom digest to 0cd97b7
([#3260](#3260))
([2d54a5d](2d54a5d))
* update grpc dependencies to v1.67.1
([#3258](#3258))
([e08906c](e08906c))
* update grpc dependencies to v1.67.1 in dependencies.properties
([#3279](#3279))
([5b46e70](5b46e70))
* update junit5 monorepo to v5.11.2
([#3276](#3276))
([6b10f94](6b10f94))
* update netty dependencies to v4.1.114.final
([#3263](#3263))
([8bd83d9](8bd83d9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnauthenticationException when customizing universe-domain when quota project id is set
3 participants
@mpeddada1 @lqiu96 @blakeli0